Project

General

Profile

Actions

Bug #8142

closed

Technique editor no more usable if mismatched/unclosed ${} $() in input

Added by Nicolas CHARLES almost 8 years ago. Updated almost 2 years ago.

Status:
Rejected
Priority:
1
Assignee:
-
Category:
Web - Technique editor
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

If I make a typo, and use a variable like ${) (curly bracket + parenthesis), i get the following error message, which is super unhelpful

An Error occured! Could not write technique 'broken' from path /var/rudder/configuration-repository/ncf, cause is: Error while running post-hook command [u'/var/rudder/configuration-repository/ncf/ncf-hooks.d/post.write_technique.rudderify.sh', u'/var/rudder/configuration-repository/ncf', u'broken']
Details: INFO: Alternative source path added: /var/rudder/configuration-repository/ncf Traceback (most recent call last): File "/usr/share/ncf/tools/ncf_rudder.py", line 372, in write_one_technique_for_rudder(sys.argv[2],sys.argv[3]) File "/usr/share/ncf/tools/ncf_rudder.py", line 43, in write_one_technique_for_rudder techniques = ncf.get_all_techniques_metadata(alt_path='/var/rudder/configuration-repository/ncf')['data'] File "/usr/share/ncf/tools/ncf.py", line 499, in get_all_techniques_metadata method_calls = parse_technique_methods(file) File "/usr/share/ncf/tools/ncf.py", line 260, in parse_technique_methods promises = json.loads(out) File "/usr/lib64/python2.6/json/__init__.py", line 307, in loads return _default_decoder.decode(s) File "/usr/lib64/python2.6/json/decoder.py", line 319, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/usr/lib64/python2.6/json/decoder.py", line 338, in raw_decode raise ValueError("No JSON object could be decoded") ValueError: No JSON object could be decoded 

We should predetect it when we hit save (or while typing it)


Related issues 1 (0 open1 closed)

Related to Rudder - Bug #10268: technique editor return error 500 and /var/rudder/ncf/50_techniques/ emptyReleasedFrançois ARMANDActions
Actions #1

Updated by Nicolas CHARLES almost 8 years ago

  • Translation missing: en.field_tag_list set to sponsored
Actions #2

Updated by Vincent MEMBRÉ almost 8 years ago

  • Status changed from New to In progress
Actions #3

Updated by Alexis Mousset over 7 years ago

  • Category set to Technique editor - API
Actions #4

Updated by Nicolas CHARLES about 7 years ago

  • Related to Bug #10268: technique editor return error 500 and /var/rudder/ncf/50_techniques/ empty added
Actions #5

Updated by François ARMAND about 7 years ago

  • Subject changed from Unhelpful error message when using mismatched ${} $() in technique editor to Technique editor no more usable if mismatched/unclosed ${} $() in input
Actions #6

Updated by Jonathan CLARKE about 7 years ago

  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
Actions #7

Updated by Jonathan CLARKE almost 7 years ago

  • Status changed from In progress to New
  • Priority set to 51
Actions #8

Updated by Jonathan CLARKE almost 7 years ago

  • Assignee deleted (Vincent MEMBRÉ)
Actions #9

Updated by Benoît PECCATTE almost 7 years ago

  • Severity changed from Major - prevents use of part of Rudder | no simple workaround to Minor - inconvenience | misleading | easy workaround
  • Priority changed from 51 to 35

I cannot reproduce.
With ${) the editor doesn't produce any error (tested on 0.x and 1.1)
The agent raise an error when run.
No report is done, wich means it will appear as a missing in the interface.

So downgrading to minor.

Actions #10

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 0.x to 3.1.25
  • Priority changed from 35 to 48
Actions #11

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.25 to 387
  • Priority changed from 48 to 54
Actions #12

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 387 to 4.1.10
Actions #13

Updated by Benoît PECCATTE about 6 years ago

  • Status changed from New to Rejected

This error doesn't happen anymore

Actions #14

Updated by Alexis Mousset almost 2 years ago

  • Project changed from 41 to Rudder
  • Category changed from Technique editor - API to Web - Technique editor
  • Priority changed from 54 to 0
Actions

Also available in: Atom PDF