Actions
User story #8248
closedWithout config changes, two promise generation may lead to differently ordered value in promises
Status:
Rejected
Priority:
2
Assignee:
Category:
Web - Config management
Target version:
Pull Request:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:
Description
When debugging #8247, I noticed that other changes are random, creating false cache invalidation. The resutl is correct, because unordered sets of values, but a lot of things are moved around for nothing.
Example (traced with git on /var/rudder/share directory, with word diff, so look for [-xxx-] and {+yyy+}):
+++ b/share/f2ad48f3-66b8-4270-9fd6-cf3c0426034b/rules/cfengine-community/checkGenericFileContent/5.0/checkGenericFileContent.cf .... @@ -104,8 +104,8 @@ bundle agent check_generic_file_content { "generic_file_content_owner[25]" string => "expd_of"; "generic_file_content_owner[26]" string => "root"; "generic_file_content_owner[27]" string => "root"; "generic_file_content_owner[28]" string => "$([-root-]{+generic_variable_definition.expuser+})"; "generic_file_content_owner[29]" string => "[-generic_variable_definition.expuser-]{+root+}"; "generic_file_content_owner[30]" string => "root"; "generic_file_content_owner[31]" string => "root"; "generic_file_content_owner[32]" string => "root"; ...
Or:
+++ b/share/f2ad48f3-66b8-4270-9fd6-cf3c0426034b/rules/cfengine-community/copyGitFile/1.5/copyFileFromSharedFolder.cf @@ -25,8 +25,8 @@ bundle agent download_from_shared_folder ..... "copyfile[4][name]" string => "sources/[-drush/drush-]{+postgresql/postgresql+}-$(generic_variable_definition.version_[-drush).tgz-]{+postgresql).run+}"; "copyfile[5][name]" string => "sources/[-postgresql/postgresql-]{+drush/drush+}-$(generic_variable_definition.version_[-postgresql).run-]{+drush).tgz+}"; .....
Not sur we can do something, because order may have a meaning in the general case, but it's really not clean as it is.
Actions