Project

General

Profile

Actions
Copy link

Bug #8453

closed

Change in group may be overwritten by dynamic group update

Added by Nicolas CHARLES almost 8 years ago. Updated almost 2 years ago.

Status:
Released
Priority:
1
Assignee:
Nicolas CHARLES
Category:
Web - Nodes & inventories
Target version:
2.11.22
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

If we are unlucky enough to edit a group right when the dynamic group update is running, and saving this specific group, we may have all of our change that is overwritten
In DynGroupUpdater, we:
  1. load the group
  2. check it's dynamic
  3. get its query
  4. compute new members
  5. save it if they change

Last step should ensure that:
- we don't overwrite query
- if query changed between step 3 and save, rerun the update

Result can be pretty surprising, as group config looks ok, but isn't

Actions
Copy link

Also available in: Atom PDF