User story #9204: Clean up unused NodeXXXModified events - Rudder - Issue Tracker

Actions

Copy link

User story #9204

closed

User story #1808: Add an Audit mode to Rudder: only check properties, no modification on nodes

User story #8924: Policy mode API (Global, Directive, Node)

Clean up unused NodeXXXModified events

Added by François ARMAND about 8 years ago. Updated about 8 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Vincent MEMBRÉ

Category:

Web - Maintenance

Target version:

4.0.0~rc1

Pull Request:

https://github.com/Normation/rudder/p...

UX impact:

Suggestion strength:

User visibility:

Effort required:

Name check:

Fix check:

Regression:

Description

With the parent ticket, we are merging several disjoint events related to node into a new "node properties" event.

For now, the implementation is able to read both old events and new ones, and so we are assure that old archives and events in the DB are still correctly readable.
But we need to do a migration so that we have a release from which we can say "starting now, we don't have to care about old disjoint node properties". And so be able to remove the code diffenitly after a couple of version;

UPDATE: read comments to see why actually, we don't need that migration.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by François ARMAND about 8 years ago

Target version set to 4.0.0~rc2

Actions

Copy link

Updated by François ARMAND about 8 years ago

Related to Architecture #9202: Clean old fileFormat migration and fileFormat numbering policy added

Actions

Copy link

Updated by François ARMAND about 8 years ago

With some more looking, we don't need a migration:

- the 3.2 eventlog details (the XML part) for node ("NodeHeartbeatModified", "NodePropertiesModified", "NodeAgentRunPeriodModified") have the same structure "NodeModified", so that the unserialisation of a NodeModified correctly unserialize the 3 old one ;
- in 4.0, we are only producing "ModifyNodeEventType" eventType, whereas in 3.2 we were producing "ModifyNodeHeartbeatEventType", "ModifyNodePropertiesEventType" and "ModifyNodeAgentRunPeriodEventType". So we just have to say that now, the 3 old eventType for node are mapped to the new "ModifyNodeEventType"

With that, we don't have to change the file format nor the eventType. The only modification if to have ModifyNodeEventType mapped from 4 string in place of one - something that we can afford to maintain.

Actions

Copy link