Project

General

Custom queries

Profile

Actions

Bug #9222

closed

Wrong detection of rudder init parameters

Added by Alexis Mousset over 8 years ago. Updated over 8 years ago.

Status:
Released
Priority:
N/A
Category:
System integration
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

On CentOS 7, allowed networks after a rudder-setup install are:

192.168.0.42/24
no
yes
yes
192.168.0.42/24

Which breaks things.

Actions #1

Updated by Alexis Mousset over 8 years ago

Looks like an error in detection of argument number (old/new syntax).

Actions #4

Updated by Benoît PECCATTE over 8 years ago

It looks like someone called the script with the old parameters, since we removed the old call convention in 4.0

Actions #5

Updated by Benoît PECCATTE over 8 years ago

Do you think it's too fast to change it in 4.0 ?

We should at least check that we only add valid IPs so that we don't break anything.

Actions #6

Updated by Alexis Mousset over 8 years ago

Well it was rudder-setup called by rtf that still uses the old paramaters ;) I don't think it is a problem to change this in 4.0 as installation procedure needs to be reviewed/changed anyway.

Actions #8

Updated by Benoît PECCATTE over 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Benoît PECCATTE to Alexis Mousset
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/1097
Actions #9

Updated by Benoît PECCATTE over 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #13

Updated by Alexis Mousset over 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.0.0 which was released the 10th November 2016.

Actions

Also available in: Atom PDF