Actions
Bug #9869
closed
Compliance on all reports is always computed, even when not necessary
Status:
Released
Priority:
N/A
Assignee:
Category:
Performance and scalability
Target version:
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:
Description
Class ComplianceLevel always computes compliance at instantiation; and a lot of them can be created (there is one per rapport, plus one per component, plus one per directive, plus one per rule, time the number of nodes)
This computation is by itself not that time consuming ( 11 division, and BugDecimal toDouble), but it adds up to a lot of unecessary computation, especially when object are then thrown away
Converting it all to lazy yields minimal improvement in 3.1 (between 5 to 30% improvement for compliance computations), and dramatic improvement in 4.0 (HomePage goes from 4s when 1000 nodes updated their promises to 1 s)
Updated by Nicolas CHARLES over 7 years ago
- Status changed from New to In progress
Updated by Nicolas CHARLES over 7 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Nicolas CHARLES to Vincent MEMBRÉ
- Pull Request set to https://github.com/Normation/rudder/pull/1413
Updated by Nicolas CHARLES over 7 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset rudder|8982bce4c17abc4f955d3f053f6084aa92644064.
Updated by Nicolas CHARLES over 7 years ago
- Has duplicate Bug #9864: getNodeStatusReports is called for each node, and is slow to compute PolicyMode Inconsistency added
Updated by Vincent MEMBRÉ about 7 years ago
- Status changed from Pending release to Released
Actions