Project

General

Profile

Actions
Copy link

Bug #11613

closed

generic_variable_definition inserts spaces in multi lined values

Bug #11613: generic_variable_definition inserts spaces in multi lined values

Added by Janos Mattyasovszky over 8 years ago. Updated over 8 years ago.

Status:
Released
Priority:
N/A
Assignee:
Alexis Mousset
Category:
Techniques
Target version:
3.1.24
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Priority:
52
Name check:
Fix check:
Regression:

Description

If you have a generic_variable_definition value that consists of multiple lines, due to how the .st file is built up, it inserts spaces as of the second line, indenting the content.

    &GENERIC_VARIABLE_NAME, GENERIC_VARIABLE_CONTENT:{name, content |"&name&" string => "&content&",

https://github.com/Normation/rudder-techniques/blob/91dc9d9e48d300afd76edcf37a961fa7069a3d5a/techniques/systemSettings/misc/genericVariableDefinition/2.0/genericVariableDefinition.st#L24

Resulting generated code example:

    "var_authorized_key_final" string => "${generic_variable_definition.auth_key_1}
    ${generic_variable_definition.auth_key_2}",

That results in a content, when written to a file:

ssh-rsa AAAAB3NzaC1yc2EAAA
    ssh-rsa AAAAB3NzaC1yc2

Subtasks 1 (0 open — 1 closed)

Bug #11629: Same as parent ticket for technique "Variables (any)"ReleasedAlexis MoussetActions

Updated by Nicolas CHARLES over 8 years ago Actions
Copy link
 #1

Hi Janos
How can you multiline with this technique ?

Updated by Janos Mattyasovszky over 8 years ago Actions
Copy link
 #2

  • Description updated (diff)

Updated by Janos Mattyasovszky over 8 years ago Actions
Copy link
 #3

  • Description updated (diff)

Updated by Florian Heigl over 8 years ago Actions
Copy link
 #4

it is my understanding that this use was never indented.
now the question is if it would be possible to fix it to actually work, since it seems to be pretty close to working.

Updated by Janos Matya over 8 years ago Actions
Copy link
 #5

You just have to remove some spaces in front of the variable substitution of string template, the diff is basically about 6x [space]...

Updated by Nicolas CHARLES over 8 years ago Actions
Copy link
 #6

  • Assignee set to Nicolas CHARLES
  • Target version set to 3.1.24

Updated by Nicolas CHARLES over 8 years ago Actions
Copy link
 #7

  • Status changed from New to In progress

Updated by Nicolas CHARLES over 8 years ago Actions
Copy link
 #8

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Alexis Mousset
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1212

Updated by Nicolas CHARLES over 8 years ago Actions
Copy link
 #9

  • Status changed from Pending technical review to Pending release

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #10

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.1.24, 4.1.8 and 4.2.1 which were released today.

Actions
Copy link

Also available in: PDF Atom