Project

General

Profile

Bug #11683

Process management: stopped sends multiple reports.

Added by Janos Mattyasovszky about 1 year ago. Updated 5 months ago.

Status:
Released
Priority:
N/A
Category:
Techniques
Target version:
Severity:
Minor - inconvenience | misleading | easy workaround
User visibility:
Getting started - demo | first install | level 1 Techniques
Effort required:
Small
Priority:
58

Description

I have tried to stop a service and ensure it's stopped / not started with the Rudder Technique.

Filled fields were:

Service name (as seen in chkconfig or systemctl, or Windows tasks):  [ fail2ban ]
This process should be: (o) Stopped
This service should be set to start on boot: (o) No
When stopping this process: (o) Stop gracefully (service xxx stop)

The field Process name (full path to the executable, to be check in 'ps' output) was not filled in because the UI did not complain about it not being set, but if that is the case, there appears to be a reporting error:

fail2ban    
[Unexpected] Process of fail2ban was stopped
[Unexpected] Cannot check the status of fail2ban: the process name is not filed

After filling in the Process name field, I got a 100% green compliance.

The Technique should either require the field to be filled or not send double reports.

(version rudder-agent-4.1.8.release-1.SLES.11)

Associated revisions

Revision c90641ca (diff)
Added by Félix DALLIDET 6 months ago

Fixes #11683: Process management: stopped sends multiple reports.

Revision e29fe8ce
Added by Fdall 6 months ago

Merge pull request #1309 from Fdall/bug_11683/process_management_stopped_sends_multiple_reports

Fixes #11683: Process management: stopped sends multiple reports.

History

#1 Updated by Janos Mattyasovszky about 1 year ago

  • Description updated (diff)

#2 Updated by Benoît PECCATTE about 1 year ago

  • Effort required set to Small
  • Priority changed from 50 to 66

#3 Updated by Benoît PECCATTE 10 months ago

  • Priority changed from 66 to 64

This happens when the process range is filled, because the number of processes is counted via ps.
I think we should clearly state this in the help.
Moreover the "was stopped" message should not be unexpected

Was the "process range" field filled in your directive ?

#4 Updated by Benoît PECCATTE 6 months ago

  • Assignee set to Félix DALLIDET
  • Priority changed from 64 to 60

#5 Updated by Félix DALLIDET 6 months ago

  • Target version set to 4.1.13

The technique should not check if the process is active or not if the field name was not filled and should be reporting an error if:
-the name field is empty and "Running" or "Stopped" are selected.
If you do not fill the field name, "Don't change" option should be selected and the technique should report a compliant report.

I will put "Don't change" as the default option.

#6 Updated by Félix DALLIDET 6 months ago

  • Status changed from New to In progress

#7 Updated by Félix DALLIDET 6 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Félix DALLIDET to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1309

#8 Updated by Félix DALLIDET 6 months ago

The technique behaviour is very confusing, changing the sections display may help to understand how it works.

#9 Updated by Félix DALLIDET 6 months ago

  • Status changed from Pending technical review to Pending release

#10 Updated by Anonymous 6 months ago

#11 Updated by Vincent MEMBRÉ 5 months ago

  • Status changed from Pending release to Released
  • Priority changed from 60 to 58

This bug has been fixed in Rudder 4.1.13, 4.2.7 and 4.3.3 which were released today.

Also available in: Atom PDF