Project

General

Profile

Actions
Copy link

Bug #12968

open

We cannot used non-latin name in Technique Editor for Technique Name

Added by Nicolas CHARLES over 6 years ago. Updated 5 months ago.

Status:
In progress
Priority:
N/A
Assignee:
Elaad FURREEDAN
Category:
Web - Technique editor
Target version:
7.3.17
Pull Request:
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
I dislike using that feature
User visibility:
Getting started - demo | first install | Technique editor and level 1 Techniques
Effort required:
Medium
Priority:
58
Name check:
Fix check:
Regression:
No

Description

I wnted to create a Technique with name "Зарегистрируйтесь" - but it prevented me to create the Technique, as the Bundle name became __________________________

Зарегистрируйтесь is a totally valid bundle name (but it does canonify to __________________________ though)

Files

clipboard-202303021725-isiu6.png (23.8 KB) clipboard-202303021725-isiu6.png François ARMAND, 2023-03-02 17:25
Actions
Copy link
 #1

Updated by Nicolas CHARLES over 6 years ago

simply allowing non-ascii in the JS is not enough, as it fails to create the file 

[Mon Jul 16 08:10:18.479137 2018] [wsgi:error] [pid 6519:tid 139935183329024] ERROR: Unknown internal error during technique writing
[Mon Jul 16 08:10:18.479164 2018] [wsgi:error] [pid 6519:tid 139935183329024] Cause: 'ascii' codec can't encode characters in position 55-71: ordinal not in range(128)
[Mon Jul 16 08:10:18.479167 2018] [wsgi:error] [pid 6519:tid 139935183329024] Traceback (most recent call last):
[Mon Jul 16 08:10:18.479169 2018] [wsgi:error] [pid 6519:tid 139935183329024]   File "/usr/share/ncf/api/ncf_api_flask_app/views.py", line 155, in create_technique
[Mon Jul 16 08:10:18.479171 2018] [wsgi:error] [pid 6519:tid 139935183329024]     result = ncf.write_technique(technique,path)
[Mon Jul 16 08:10:18.479173 2018] [wsgi:error] [pid 6519:tid 139935183329024]   File "/usr/share/ncf/tools/ncf.py", line 613, in write_technique
[Mon Jul 16 08:10:18.479175 2018] [wsgi:error] [pid 6519:tid 139935183329024]     filename = os.path.realpath(os.path.join(path, "50_techniques", bundle_name, bundle_name+".cf"))
[Mon Jul 16 08:10:18.479177 2018] [wsgi:error] [pid 6519:tid 139935183329024]   File "/usr/lib/python2.7/posixpath.py", line 375, in realpath
[Mon Jul 16 08:10:18.479179 2018] [wsgi:error] [pid 6519:tid 139935183329024]     path, ok = _joinrealpath('', filename, {})
[Mon Jul 16 08:10:18.479180 2018] [wsgi:error] [pid 6519:tid 139935183329024]   File "/usr/lib/python2.7/posixpath.py", line 400, in _joinrealpath
[Mon Jul 16 08:10:18.479182 2018] [wsgi:error] [pid 6519:tid 139935183329024]     if not islink(newpath):
[Mon Jul 16 08:10:18.479184 2018] [wsgi:error] [pid 6519:tid 139935183329024]   File "/usr/lib/python2.7/posixpath.py", line 135, in islink
[Mon Jul 16 08:10:18.479186 2018] [wsgi:error] [pid 6519:tid 139935183329024]     st = os.lstat(path)
[Mon Jul 16 08:10:18.479197 2018] [wsgi:error] [pid 6519:tid 139935183329024] UnicodeEncodeError: 'ascii' codec can't encode characters in position 55-71: ordinal not in range(128)

Actions
Copy link
 #2

Updated by Benoît PECCATTE over 6 years ago

  • Target version changed from 4.1.14 to 4.1.15
Actions
Copy link
 #3

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.15 to 4.1.16
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.16 to 4.1.17
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.17 to 4.1.18
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.18 to 4.1.19
Actions
Copy link
 #7

Updated by Alexis Mousset almost 6 years ago

  • Target version changed from 4.1.19 to 4.1.20
Actions
Copy link
 #8

Updated by François ARMAND over 5 years ago

  • Target version changed from 4.1.20 to 4.1.21
Actions
Copy link
 #9

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.21 to 4.1.22
Actions
Copy link
 #10

Updated by François ARMAND over 5 years ago

  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Getting started - demo | first install | Technique editor and level 1 Techniques
  • Priority changed from 0 to 44

I'm setting it to "minor" because the workaround it rather simple to find (it's a common problem). But that bug is really a pitty :/

Actions
Copy link
 #11

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.22 to 4.1.23
  • Priority changed from 44 to 43
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.23 to 4.1.24
Actions
Copy link
 #13

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.24 to 588
  • Priority changed from 43 to 42
Actions
Copy link
 #14

Updated by Alexis Mousset over 5 years ago

  • Target version changed from 588 to 5.0.13
Actions
Copy link
 #15

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 5.0.13 to 5.0.14
Actions
Copy link
 #16

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 5.0.14 to 5.0.15
Actions
Copy link
 #17

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 5.0.15 to 5.0.16
Actions
Copy link
 #18

Updated by Alexis Mousset almost 5 years ago

  • Target version changed from 5.0.16 to 5.0.17
Actions
Copy link
 #19

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.17 to 5.0.18
Actions
Copy link
 #20

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.18 to 5.0.19
Actions
Copy link
 #21

Updated by Vincent MEMBRÉ about 4 years ago

  • Target version changed from 5.0.19 to 5.0.20
Actions
Copy link
 #22

Updated by Vincent MEMBRÉ about 4 years ago

  • Target version changed from 5.0.20 to 797
Actions
Copy link
 #23

Updated by Benoît PECCATTE over 3 years ago

  • Target version changed from 797 to 6.1.14
Actions
Copy link
 #24

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 6.1.14 to 6.1.15
Actions
Copy link
 #25

Updated by Vincent MEMBRÉ over 3 years ago

  • Target version changed from 6.1.15 to 6.1.16
Actions
Copy link
 #26

Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 6.1.16 to 6.1.17
  • Priority changed from 42 to 43
Actions
Copy link
 #27

Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 6.1.17 to 6.1.18
  • Priority changed from 43 to 44
Actions
Copy link
 #28

Updated by Vincent MEMBRÉ almost 3 years ago

  • Target version changed from 6.1.18 to 6.1.19
Actions
Copy link
 #29

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.19 to 6.1.20
  • Priority changed from 44 to 45
Actions
Copy link
 #30

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.20 to 6.1.21
  • Priority changed from 45 to 46
Actions
Copy link
 #31

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 6.1.21 to old 6.1 issues to relocate
Actions
Copy link
 #32

Updated by François ARMAND over 1 year ago

  • Target version changed from old 6.1 issues to relocate to 7.2.5
  • UX impact set to I dislike using that feature
  • Priority changed from 46 to 73
  • Regression set to No
Actions
Copy link
 #34

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.2.5 to 7.2.6
Actions
Copy link
 #35

Updated by Elaad FURREEDAN over 1 year ago

  • Status changed from New to In progress
  • Assignee set to Elaad FURREEDAN
Actions
Copy link
 #36

Updated by Elaad FURREEDAN over 1 year ago

  • Effort required set to Medium
  • Priority changed from 73 to 57

It's a bit tricky because we use the regex [^_a-zA-Z\\d]
If we want to match non-latin characters, I think we can use \p{L} to match letter that are not Latin, but it will include characters that we don't want ($,{}, @ etc)

I think we should list all characters that we definitely don't want

Actions
Copy link
 #37

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.2.6 to 7.2.7
Actions
Copy link
 #38

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.2.7 to 7.2.8
Actions
Copy link
 #39

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.2.8 to 7.2.9
  • Priority changed from 57 to 58
Actions
Copy link
 #40

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 7.2.9 to 7.2.10
Actions
Copy link
 #41

Updated by Alexis Mousset over 1 year ago

  • Target version changed from 7.2.10 to 7.2.11
Actions
Copy link
 #42

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 7.2.11 to 1046
Actions
Copy link
 #43

Updated by Alexis Mousset about 1 year ago

  • Target version changed from 1046 to 7.3.8
Actions
Copy link
 #44

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 7.3.8 to 7.3.9
Actions
Copy link
 #45

Updated by Vincent MEMBRÉ about 1 year ago

  • Target version changed from 7.3.9 to 7.3.10
Actions
Copy link
 #46

Updated by Vincent MEMBRÉ 12 months ago

  • Target version changed from 7.3.10 to 7.3.11
Actions
Copy link
 #47

Updated by Vincent MEMBRÉ 10 months ago

  • Target version changed from 7.3.11 to 7.3.12
Actions
Copy link
 #48

Updated by Vincent MEMBRÉ 9 months ago

  • Target version changed from 7.3.12 to 7.3.13
Actions
Copy link
 #49

Updated by Vincent MEMBRÉ 9 months ago

  • Target version changed from 7.3.13 to 7.3.14
Actions
Copy link
 #50

Updated by Vincent MEMBRÉ 7 months ago

  • Target version changed from 7.3.14 to 7.3.15
Actions
Copy link
 #51

Updated by Vincent MEMBRÉ 6 months ago

  • Target version changed from 7.3.15 to 7.3.16
Actions
Copy link
 #52

Updated by Vincent MEMBRÉ 5 months ago

  • Target version changed from 7.3.16 to 7.3.17
Actions
Copy link

Also available in: Atom PDF