Project

General

Profile

Actions

Bug #14790

closed

Deleted directives are not always removed from rule (and are then not actionnable)

Added by Benoît PECCATTE about 2 years ago. Updated over 1 year ago.

Status:
Released
Priority:
N/A
Category:
Web - Compliance & node report
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Very Small
Priority:
73

Description

At least in rudder 5.0

When a directive that was previously used in a rule is removed (I don't know how) the generation fails with the message "Cannot build Rule vars".
The only way to work around this is to modify the rule (ex changing the description) and save it.


Files

Actions #1

Updated by François ARMAND about 2 years ago

  • Subject changed from When a directive doesn't exist anymore generation may fail to Deleted directive are not always remove from rule and not actionnable
  • Target version set to 5.0.10
  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Operational - other Techniques | Rudder settings | Plugins
  • Effort required set to Small
  • Priority changed from 0 to 67

I think that the fact that the generation fails is what is expected. But the problem seems more to be that if you go to the rule, you don't see that there is a directive in that rule which doesn't exist anymore.
We should display a directive box with an error, with at least the directive ID. Moreover, it would allow to remove it and save the rule.

I'm setting the criticity to "major", because it's not clear at all what the user need to do to be able to make a generation works again.

Actions #2

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 5.0.10 to 5.0.11
Actions #3

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 5.0.11 to 5.0.12
Actions #4

Updated by Vincent MEMBRÉ almost 2 years ago

  • Target version changed from 5.0.12 to 5.0.13
  • Priority changed from 67 to 66
Actions #5

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 5.0.13 to 5.0.14
  • Priority changed from 66 to 64
Actions #6

Updated by Vincent MEMBRÉ over 1 year ago

  • Target version changed from 5.0.14 to 5.0.15
  • Priority changed from 64 to 63
Actions #7

Updated by François ARMAND over 1 year ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
  • Priority changed from 63 to 62
Actions #8

Updated by François ARMAND over 1 year ago

Now they appear in red "error" (cf screenshot)

Actions #9

Updated by François ARMAND over 1 year ago

  • Category set to Web - Compliance & node report
  • Target version set to 5.0.15
  • User visibility set to Operational - other Techniques | Rudder settings | Plugins
  • Effort required set to Very Small
  • Priority changed from 0 to 74
Actions #10

Updated by François ARMAND over 1 year ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/2597
Actions #11

Updated by François ARMAND over 1 year ago

  • Status changed from Pending technical review to Pending release
Actions #12

Updated by Vincent MEMBRÉ over 1 year ago

  • Priority changed from 74 to 73
Actions #14

Updated by Alexis MOUSSET over 1 year ago

  • Subject changed from Deleted directive are not always remove from rule and not actionnable to Deleted directives are not always removed from rule (and are then not actionnable)
Actions #16

Updated by Vincent MEMBRÉ over 1 year ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.15 which was released today.

Actions

Also available in: Atom PDF