Bug #14790
closed
Deleted directives are not always removed from rule (and are then not actionnable)
Added by Benoît PECCATTE over 5 years ago.
Updated almost 5 years ago.
Category:
Web - Compliance & node report
Severity:
Major - prevents use of part of Rudder | no simple workaround
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Very Small
Description
At least in rudder 5.0
When a directive that was previously used in a rule is removed (I don't know how) the generation fails with the message "Cannot build Rule vars".
The only way to work around this is to modify the rule (ex changing the description) and save it.
Files
- Subject changed from When a directive doesn't exist anymore generation may fail to Deleted directive are not always remove from rule and not actionnable
- Target version set to 5.0.10
- Severity set to Major - prevents use of part of Rudder | no simple workaround
- User visibility set to Operational - other Techniques | Rudder settings | Plugins
- Effort required set to Small
- Priority changed from 0 to 67
I think that the fact that the generation fails is what is expected. But the problem seems more to be that if you go to the rule, you don't see that there is a directive in that rule which doesn't exist anymore.
We should display a directive box with an error, with at least the directive ID. Moreover, it would allow to remove it and save the rule.
I'm setting the criticity to "major", because it's not clear at all what the user need to do to be able to make a generation works again.
- Target version changed from 5.0.10 to 5.0.11
- Target version changed from 5.0.11 to 5.0.12
- Target version changed from 5.0.12 to 5.0.13
- Priority changed from 67 to 66
- Target version changed from 5.0.13 to 5.0.14
- Priority changed from 66 to 64
- Target version changed from 5.0.14 to 5.0.15
- Priority changed from 64 to 63
- Status changed from New to In progress
- Assignee set to François ARMAND
- Priority changed from 63 to 62
Now they appear in red "error" (cf screenshot)
- Category set to Web - Compliance & node report
- Target version set to 5.0.15
- User visibility set to Operational - other Techniques | Rudder settings | Plugins
- Effort required set to Very Small
- Priority changed from 0 to 74
- Status changed from In progress to Pending technical review
- Assignee changed from François ARMAND to Vincent MEMBRÉ
- Pull Request set to https://github.com/Normation/rudder/pull/2597
- Status changed from Pending technical review to Pending release
- Priority changed from 74 to 73
- Fix check set to To do
- Subject changed from Deleted directive are not always remove from rule and not actionnable to Deleted directives are not always removed from rule (and are then not actionnable)
- Name check changed from To do to Reviewed
- Fix check changed from To do to Checked
- Status changed from Pending release to Released
This bug has been fixed in Rudder 5.0.15 which was released today.
- Related to Bug #19873: Saving a rule with deleted directives/groups does not correct it added
- Related to Bug #19786: When we delete a directive, it's not removed from the rules added
Also available in: Atom
PDF