Project

General

Profile

Actions
Copy link

Bug #14790

closed

Deleted directives are not always removed from rule (and are then not actionnable)

Added by Benoît PECCATTE over 5 years ago. Updated almost 5 years ago.

Status:
Released
Priority:
N/A
Assignee:
Vincent MEMBRÉ
Category:
Web - Compliance & node report
Target version:
5.0.15
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Operational - other Techniques | Rudder settings | Plugins
Effort required:
Very Small
Priority:
73
Name check:
Reviewed
Fix check:
Checked
Regression:

Description

At least in rudder 5.0

When a directive that was previously used in a rule is removed (I don't know how) the generation fails with the message "Cannot build Rule vars".
The only way to work around this is to modify the rule (ex changing the description) and save it.

Files

2019-11-14_11.42.08-Rudder_-_Rules_Management.png (11.9 KB) 2019-11-14_11.42.08-Rudder_-_Rules_Management.png François ARMAND, 2019-11-14 11:43

Related issues 2 (0 open — 2 closed)

Related to Rudder - Bug #19873: Saving a rule with deleted directives/groups does not correct itReleasedRaphael GAUTHIERActions
Related to Rudder - Bug #19786: When we delete a directive, it's not removed from the rulesReleasedVincent MEMBRÉActions
Actions
Copy link
 #1

Updated by François ARMAND over 5 years ago

  • Subject changed from When a directive doesn't exist anymore generation may fail to Deleted directive are not always remove from rule and not actionnable
  • Target version set to 5.0.10
  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Operational - other Techniques | Rudder settings | Plugins
  • Effort required set to Small
  • Priority changed from 0 to 67

I think that the fact that the generation fails is what is expected. But the problem seems more to be that if you go to the rule, you don't see that there is a directive in that rule which doesn't exist anymore.
We should display a directive box with an error, with at least the directive ID. Moreover, it would allow to remove it and save the rule.

I'm setting the criticity to "major", because it's not clear at all what the user need to do to be able to make a generation works again.

Actions
Copy link
 #2

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 5.0.10 to 5.0.11
Actions
Copy link
 #3

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 5.0.11 to 5.0.12
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 5.0.12 to 5.0.13
  • Priority changed from 67 to 66
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 5.0.13 to 5.0.14
  • Priority changed from 66 to 64
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 5.0.14 to 5.0.15
  • Priority changed from 64 to 63
Actions
Copy link
 #7

Updated by François ARMAND about 5 years ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
  • Priority changed from 63 to 62
Actions
Copy link
 #8

Updated by François ARMAND about 5 years ago

Now they appear in red "error" (cf screenshot)

Actions
Copy link
 #9

Updated by François ARMAND about 5 years ago

  • Category set to Web - Compliance & node report
  • Target version set to 5.0.15
  • User visibility set to Operational - other Techniques | Rudder settings | Plugins
  • Effort required set to Very Small
  • Priority changed from 0 to 74
Actions
Copy link
 #10

Updated by François ARMAND about 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/2597
Actions
Copy link
 #11

Updated by François ARMAND about 5 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ about 5 years ago

  • Priority changed from 74 to 73
  • Fix check set to To do
Actions
Copy link
 #13

Updated by Vincent MEMBRÉ about 5 years ago

  • Name check set to To do
Actions
Copy link
 #14

Updated by Alexis Mousset about 5 years ago

  • Subject changed from Deleted directive are not always remove from rule and not actionnable to Deleted directives are not always removed from rule (and are then not actionnable)
  • Name check changed from To do to Reviewed
Actions
Copy link
 #15

Updated by François ARMAND about 5 years ago

  • Fix check changed from To do to Checked
Actions
Copy link
 #16

Updated by Vincent MEMBRÉ almost 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 5.0.15 which was released today.

Actions
Copy link
 #17

Updated by François ARMAND about 3 years ago

  • Related to Bug #19873: Saving a rule with deleted directives/groups does not correct it added
Actions
Copy link
 #18

Updated by François ARMAND about 3 years ago

  • Related to Bug #19786: When we delete a directive, it's not removed from the rules added
Actions
Copy link

Also available in: Atom PDF