Bug #16241
closed
Improve reliability and error reporting of report upload in agent
Description
I suppose you are aware but ... the agent modifications for https protocol seem unfinished.
E| n/a sshKeyDistribution Flush SSH file tze The keys for user tze were not requested to be flush
E| n/a sshKeyDistribution Flush SSH file monitoring key The keys for user svcmon were not requested to be flush
E| compliant sudoParameters sudoersFile The sudoers file did not require any modification
E| compliant sudoParameters sudoersFile The sudoers file did not require any modification
E| n/a Common Monitoring No Rudder monitoring information to share with the server
## Summary #####################################################################
83 components verified in 16 directives
=> 83 components in Enforce mode
-> 63 compliant
-> 2 repaired
-> 17 not-applicable
-> 1 error
Execution time: 11.48s
################################################################################
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>201 Created</title>
</head><body>
<h1>Created</h1>
<p>Resource /reports/2019-11-21T17%3A34%3A22%2B00%3A00%40b82edcfc-6fdf-41ab-9c7f-679139cec7b4.log.gz has been created.</p>
<hr />
<address>Apache/2.4.25 (Debian) Server at 172.16.52.143 Port 443</address>
</body></html>
The posting of the reports should be wrapped in the agent output, currently it leaks for both "rudder agent run" and "rudder agent inventory"
It can be confusing because at this point the agent already completed that it finished the run. So it's done, but then it's doing another thing, that can also fail even though the agent just completed ok.
It uses a different format (html ;-) than the agent output.
This output should definitely appear no later than "Summary" and the upload should also be included in the execution time.
(I would agree that a run can be successful even if the reporting fails)
Please could you make some tests where the http dest is
- dropping the connect
- writes at 10 bytes/s
- has disk full
- is not writeable (permissions)
to check that there is timeout handling on the upload process and failed uploads ARE being caught)
The severity of this issue is best set based on the behaviour when the upload has problems.
Updated by 
Updated by 
Updated by 
Updated by