Project

General

Profile

Actions
Copy link

Bug #1925

closed

The 'Hosts settings' Technique should validate the IP address

Added by Nicolas CHARLES about 13 years ago. Updated over 9 years ago.

Status:
Released
Priority:
3
Assignee:
Nicolas CHARLES
Category:
Techniques
Target version:
3.0.0~beta2
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

We can add non-valid IP address, which can leads to some issues. We should validate this field with a regular expression

Actions
Copy link
 #1

Updated by François ARMAND about 13 years ago

  • Target version changed from 18 to 24
Actions
Copy link
 #2

Updated by Jonathan CLARKE over 12 years ago

  • Target version changed from 24 to Ideas (not version specific)
Actions
Copy link
 #3

Updated by Nicolas CHARLES almost 12 years ago

  • Category changed from Policy Templates to Techniques
  • Status changed from New to Discussion
  • Assignee set to Jonathan CLARKE

I'm not sure this make sense actually, as we can fill several IP for a given host
Jon, what do you think of that ?

Actions
Copy link
 #4

Updated by Jonathan CLARKE almost 12 years ago

  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES

Nicolas CHARLES wrote:

I'm not sure this make sense actually, as we can fill several IP for a given host
Jon, what do you think of that ?

I still think we should validate an IP address as such if we can. If there is a way to give several IPs (I'm not aware of this), then there must be a list syntax ie "IP1, IP2", so we should validate that in the UI too, to avoid any surprises.

Actions
Copy link
 #5

Updated by Nicolas CHARLES almost 12 years ago

  • Status changed from Discussion to 8

Jonathan CLARKE wrote:

Nicolas CHARLES wrote:

I'm not sure this make sense actually, as we can fill several IP for a given host
Jon, what do you think of that ?

I still think we should validate an IP address as such if we can. If there is a way to give several IPs (I'm not aware of this), then there must be a list syntax ie "IP1, IP2", so we should validate that in the UI too, to avoid any surprises.

Ha my mistake, you can put any text, but if you type several ip for a given host, the resulting file will be wrong.
So ok to add a regexp to enforce the IP address

Actions
Copy link
 #6

Updated by Benoît PECCATTE almost 10 years ago

  • Status changed from 8 to Pending technical review
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/598
Actions
Copy link
 #7

Updated by Benoît PECCATTE almost 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:23dfe1cee4a17c7562dbc0520e8b95d3b0a8c046.

Actions
Copy link
 #8

Updated by Jonathan CLARKE almost 10 years ago

Applied in changeset commit:314ccde616b248d079d27045dea9ebf154bb657d.

Actions
Copy link
 #9

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from Ideas (not version specific) to 3.0.0~beta2
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ over 9 years ago

  • Subject changed from The PT Hosts settings should validate the IP address to The 'Hosts settings' Technique should validate the IP address

This bug has been fixed in Rudder 3.0.0~beta2, which was released on 12-19-2014.

Actions
Copy link
 #11

Updated by Vincent MEMBRÉ over 9 years ago

  • Status changed from Pending release to Released
Actions
Copy link
 #12

Updated by Benoît PECCATTE over 9 years ago

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions
Copy link

Also available in: Atom PDF