Project

General

Profile

Actions

Bug #1925

closed

The 'Hosts settings' Technique should validate the IP address

Added by Nicolas CHARLES over 9 years ago. Updated about 6 years ago.

Status:
Released
Priority:
3
Category:
Techniques
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

We can add non-valid IP address, which can leads to some issues. We should validate this field with a regular expression

Actions #1

Updated by François ARMAND over 9 years ago

  • Target version changed from 18 to 24
Actions #2

Updated by Jonathan CLARKE almost 9 years ago

  • Target version changed from 24 to Ideas (not version specific)
Actions #3

Updated by Nicolas CHARLES over 8 years ago

  • Category changed from Policy Templates to Techniques
  • Status changed from New to Discussion
  • Assignee set to Jonathan CLARKE

I'm not sure this make sense actually, as we can fill several IP for a given host
Jon, what do you think of that ?

Actions #4

Updated by Jonathan CLARKE over 8 years ago

  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES

Nicolas CHARLES wrote:

I'm not sure this make sense actually, as we can fill several IP for a given host
Jon, what do you think of that ?

I still think we should validate an IP address as such if we can. If there is a way to give several IPs (I'm not aware of this), then there must be a list syntax ie "IP1, IP2", so we should validate that in the UI too, to avoid any surprises.

Actions #5

Updated by Nicolas CHARLES over 8 years ago

  • Status changed from Discussion to 8

Jonathan CLARKE wrote:

Nicolas CHARLES wrote:

I'm not sure this make sense actually, as we can fill several IP for a given host
Jon, what do you think of that ?

I still think we should validate an IP address as such if we can. If there is a way to give several IPs (I'm not aware of this), then there must be a list syntax ie "IP1, IP2", so we should validate that in the UI too, to avoid any surprises.

Ha my mistake, you can put any text, but if you type several ip for a given host, the resulting file will be wrong.
So ok to add a regexp to enforce the IP address

Actions #6

Updated by Benoît PECCATTE over 6 years ago

  • Status changed from 8 to Pending technical review
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/598
Actions #7

Updated by Benoît PECCATTE over 6 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:23dfe1cee4a17c7562dbc0520e8b95d3b0a8c046.

Actions #8

Updated by Jonathan CLARKE over 6 years ago

Applied in changeset commit:314ccde616b248d079d27045dea9ebf154bb657d.

Actions #9

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from Ideas (not version specific) to 3.0.0~beta2
Actions #10

Updated by Vincent MEMBRÉ about 6 years ago

  • Subject changed from The PT Hosts settings should validate the IP address to The 'Hosts settings' Technique should validate the IP address

This bug has been fixed in Rudder 3.0.0~beta2, which was released on 12-19-2014.

Actions #11

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
Actions #12

Updated by Benoît PECCATTE about 6 years ago

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions

Also available in: Atom PDF