Bug #1925: The 'Hosts settings' Technique should validate the IP address - Rudder - Issue Tracker

Custom queries

8.1 beta
Bugs triage
My TR
Need technical review
Open bugs (all)
Open bugs (UI - UX)
Open issues 8.0
Open UX defects (all)
Opened by users

Actions

Copy link

Bug #1925

closed

The 'Hosts settings' Technique should validate the IP address

Added by Nicolas CHARLES over 12 years ago. Updated about 9 years ago.

Status:

Released

Priority:

Assignee:

Nicolas CHARLES

Category:

Techniques

Target version:

3.0.0~beta2

Pull Request:

https://github.com/Normation/rudder-t...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

We can add non-valid IP address, which can leads to some issues. We should validate this field with a regular expression

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by François ARMAND over 12 years ago

Target version changed from 18 to 24

Actions

Copy link

Updated by Jonathan CLARKE almost 12 years ago

Target version changed from 24 to Ideas (not version specific)

Actions

Copy link

Updated by Nicolas CHARLES over 11 years ago

Category changed from Policy Templates to Techniques
Status changed from New to Discussion
Assignee set to Jonathan CLARKE

I'm not sure this make sense actually, as we can fill several IP for a given host
Jon, what do you think of that ?

Actions

Copy link

Updated by Jonathan CLARKE over 11 years ago

Assignee changed from Jonathan CLARKE to Nicolas CHARLES

Nicolas CHARLES wrote:

I'm not sure this make sense actually, as we can fill several IP for a given host
Jon, what do you think of that ?

I still think we should validate an IP address as such if we can. If there is a way to give several IPs (I'm not aware of this), then there must be a list syntax ie "IP1, IP2", so we should validate that in the UI too, to avoid any surprises.

Actions

Copy link

Updated by Nicolas CHARLES over 11 years ago

Status changed from Discussion to 8

Jonathan CLARKE wrote:

Nicolas CHARLES wrote:

I'm not sure this make sense actually, as we can fill several IP for a given host
Jon, what do you think of that ?

I still think we should validate an IP address as such if we can. If there is a way to give several IPs (I'm not aware of this), then there must be a list syntax ie "IP1, IP2", so we should validate that in the UI too, to avoid any surprises.

Ha my mistake, you can put any text, but if you type several ip for a given host, the resulting file will be wrong.
So ok to add a regexp to enforce the IP address

Actions

Copy link