Project

General

Profile

Actions
Copy link

Bug #19399

closed

Improve NodeInfo cache

Added by Nicolas CHARLES almost 3 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Assignee:
François ARMAND
Category:
Performance and scalability
Target version:
6.1.14
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
To do
Fix check:
Checked
Regression:

Description

When any information in LDAP about node is updated, the whole NodeInfo cache is invalidated - it's not a problem on small instances, or when there are no node properties, but on large systems with a lot of node properties, it can take more than 6 seconds, which locks virtually everything related to nodes.

Other symptoms are:
- LDAP using a lot of CPU,
- LDAP timeout in webapp logs.

We store the last modification date and all the ldap related objects, so a better strategy would be to:
  1. check if there are entries with a newer modification date
  2. if so, fetch all entries with the newer modification date
  3. construct the new nodeinfo from these entries, completing with the cache for what's missing
  4. replacing within the cache the updated entries

Subtasks 1 (0 open — 1 closed)

Bug #19466: upmerge of parent ticket is inefficientReleasedFrançois ARMANDActions

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #19369: Improve computation of cache in NodeInfoServiceRejectedFrançois ARMANDActions
Actions
Copy link
 #1

Updated by Nicolas CHARLES almost 3 years ago

  • Status changed from New to In progress
Actions
Copy link
 #2

Updated by Nicolas CHARLES almost 3 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/3668
Actions
Copy link
 #3

Updated by Nicolas CHARLES almost 3 years ago

With this change, on our test platform, updating the NodeInfo cache when properties are updated goes from 1+ second to ~45ms

Actions
Copy link
 #4

Updated by Nicolas CHARLES almost 3 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #12

Updated by Nicolas CHARLES almost 3 years ago

  • Fix check changed from To do to Checked
Actions
Copy link
 #13

Updated by Vincent MEMBRÉ almost 3 years ago

This bug has been fixed in Rudder 6.1.14 and 6.2.8 which were released today.

Actions
Copy link
 #14

Updated by Vincent MEMBRÉ almost 3 years ago

  • Status changed from Pending release to Released
Actions
Copy link
 #15

Updated by François ARMAND over 2 years ago

  • Related to Bug #19369: Improve computation of cache in NodeInfoService added
Actions
Copy link
 #16

Updated by François ARMAND over 2 years ago

  • Description updated (diff)
Actions
Copy link

Also available in: Atom PDF