Project

General

Profile

Actions
Copy link

User story #24206

closed

We need an option to force validation of change requests

Added by Clark ANDRIANASOLO 2 months ago. Updated about 2 months ago.

Status:
Released
Priority:
N/A
Assignee:
Vincent MEMBRÉ
Target version:
Rudder plugins - 7.3
Pull Request:
https://github.com/Normation/rudder-p...
UX impact:
Suggestion strength:
Want - This would make my life a lot easier but I can manage without
User visibility:
Effort required:
Small
Name check:
To do
Fix check:
Checked
Regression:
No

Description

We want to a condition that supersede all other logic on creating a change request for validation.

What we want to achieve is to have a change request in "pending validation" status, without doing all the current checks on whether nodes have changed or group is empty or not...

We want that behavior parameterized under a checkbox in the UI.

N.B. : all of this of course only affects users that are not "validated users" because those ones do not validation by construct.

Files

clipboard-202402272205-af8jn.png (70 KB) clipboard-202402272205-af8jn.png François ARMAND, 2024-02-27 22:05

Subtasks 1 (0 open — 1 closed)

Rudder - User story #24207: We need a setting to force change request validationReleasedVincent MEMBRÉActions

Related issues 3 (0 open — 3 closed)

Related to Change validation - Bug #24249: Fix typo in HTML of the setting to validate all changesReleasedFrançois ARMANDActions
Related to Rudder - Bug #24278: Incorrect error message about change request creation failure when it is not neededReleasedFrançois ARMANDActions
Has duplicate Change validation - Bug #22503: Add a property to validate all changeResolvedFrançois ARMANDActions
Actions
Copy link
 #1

Updated by Clark ANDRIANASOLO 2 months ago

  • Subtask #24207 added
Actions
Copy link
 #2

Updated by Clark ANDRIANASOLO 2 months ago

  • Status changed from New to In progress
Actions
Copy link
 #3

Updated by Clark ANDRIANASOLO 2 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Clark ANDRIANASOLO to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder-plugins/pull/659
Actions
Copy link
 #4

Updated by Clark ANDRIANASOLO 2 months ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #5

Updated by Clark ANDRIANASOLO 2 months ago

  • Has duplicate Bug #22503: Add a property to validate all change added
Actions
Copy link
 #6

Updated by Clark ANDRIANASOLO 2 months ago

  • Related to Bug #24249: Fix typo in HTML of the setting to validate all changes added
Actions
Copy link
 #7

Updated by François ARMAND 2 months ago

  • Fix check changed from To do to Error - Blocking
Actions
Copy link
 #8

Updated by François ARMAND 2 months ago

Ok, actually it works, but I get an error when:

- the "validate all check" is disable,
- no group are configured.

The, when we do a modification (hence not needing a change request), we still have the "create change request" button, and if we click on it, we get an error while the action is correctly performed.

Actions
Copy link
 #9

Updated by François ARMAND 2 months ago

  • Fix check changed from Error - Blocking to Checked
Actions
Copy link
 #10

Updated by François ARMAND 2 months ago

  • Related to Bug #24278: Incorrect error message about change request creation failure when it is not needed added
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ about 2 months ago

This bug has been fixed in Rudder plugin change-validation v8.0.6-2.3

Actions
Copy link
 #12

Updated by Vincent MEMBRÉ about 2 months ago

This bug has been fixed in Rudder plugin change-validation v7.3.12-2.3

Actions
Copy link
 #13

Updated by Vincent MEMBRÉ about 2 months ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder plugin change-validation v8.1.0.beta1-2.3

Actions
Copy link

Also available in: Atom PDF