Rudder

redmine@rudder-project.org a écrit :

Issue #3341 has been reported by Matthieu CERDA.

----------------------------------------
Implementation (development) #3341: Correct a broken time range
definition in the system promises that breaks the broken BDB detection
http://www.rudder-project.org/redmine/issues/3341

Author: Matthieu CERDA
Status: In progress
Priority: 1
Assignee: Matthieu CERDA
Category: Techniques
Target version: 2.4.4
Technical review done: No

Correct a broken time range definition in the system promises that
breaks the broken BDB detection

"mtime => irange(2147483647, ago(0,0,0,1,0,0));" is a broken
definition, that should be "mtime => irange(ago(0,0,0,1,0,0),
now);"

Matthieu, I've made some remarks on the PR, could ou correct them ?

Applied in changeset commit:4eaf4aefd6db32d179fe6cbca9282dd86c083713.

Applied in changeset commit:4ceb2af43abec26d034911d4b17ef721d0001c5a.

As tested on the labo systems, the result was that the agent considered the file to be out of range, and thus deleting the cfengine database, at each run (so every 5 minutes) (as explained in the parent ticket)
Something must have been broken in the logic or somewhere

With the implementation being "cannot find file not between now and 1 hour ago", the result is as expected :
- if the file is older than one hour, the database get erased
- if the promises are updated, the database is not erased

Applied in changeset commit:f3a39c887ff6a77f392a5496e7b775a8e36e87e5.

Applied in changeset commit:ff7ca303b395881d708f545475c0539af46a6091.

Applied in changeset commit:ff7ca303b395881d708f545475c0539af46a6091.

Nicolas CHARLES wrote:

As tested on the labo systems, the result was that the agent considered the file to be out of range, and thus deleting the cfengine database, at each run (so every 5 minutes) (as explained in the parent ticket)
Something must have been broken in the logic or somewhere

Oh, OK. I didn't know we did parent/sub tickets for bugs, my bad.

With the implementation being "cannot find file not between now and 1 hour ago", the result is as expected :
- if the file is older than one hour, the database get erased
- if the promises are updated, the database is not erased

OK, that all sounds good then.

Jonathan CLARKE wrote:

Nicolas CHARLES wrote:

As tested on the labo systems, the result was that the agent considered the file to be out of range, and thus deleting the cfengine database, at each run (so every 5 minutes) (as explained in the parent ticket)
Something must have been broken in the logic or somewhere

Oh, OK. I didn't know we did parent/sub tickets for bugs, my bad.

Actually, we don't :)
Users have been a bit overzealous in the opening tickets

With the implementation being "cannot find file not between now and 1 hour ago", the result is as expected :
- if the file is older than one hour, the database get erased
- if the promises are updated, the database is not erased

OK, that all sounds good then.

It's been deployed on orch-3 for test, and it seems ok