Project

General

Profile

Actions

User story #3664

closed

User story #3647: Techhnique "OpenSSH Server": Add possibilty to set ListenAddress

openssh techniques: add possibility to listen address

Added by Vincent MEMBRÉ almost 8 years ago. Updated over 5 years ago.

Status:
Released
Priority:
1
Assignee:
Matthieu CERDA
Category:
Techniques
Target version:
Suggestion strength:
User visibility:
Effort required:

Description

I will make a pull request from the diff sent by Dennis, and will make any corrections needed before being integrated to Rudder


Files

sshConfiguration.diff (5.98 KB) sshConfiguration.diff original patch from Dennis Cabooter Vincent MEMBRÉ, 2013-06-21 10:16
Actions #1

Updated by Vincent MEMBRÉ almost 8 years ago

  • Tracker changed from Bug to 5
  • Status changed from In progress to 10
  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
  • Target version changed from 2.4.7 to 2.6.3
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/141

The pull request was done on branch 2.6, as this is based on sshConfiguration V2.0 which only exists in 2.6

Actions #2

Updated by Nicolas PERRON almost 8 years ago

  • Target version changed from 2.6.3 to 2.6.4
Actions #3

Updated by Vincent MEMBRÉ almost 8 years ago

  • Status changed from 10 to In progress
  • Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
  • Target version changed from 2.6.4 to 2.7.0

Since there is a version 3.0 of sshCOnfiguration in 2.7.0, i'll make a new version based on 3.0 including listen addresses

Actions #4

Updated by Vincent MEMBRÉ almost 8 years ago

  • Status changed from In progress to 10
  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
  • Pull Request changed from https://github.com/Normation/rudder-techniques/pull/141 to https://github.com/Normation/rudder-techniques/pull/159
Actions #5

Updated by Jonathan CLARKE almost 8 years ago

  • Status changed from 10 to Pending technical review
  • Target version changed from 2.7.0 to 2.4.8
Actions #6

Updated by Vincent MEMBRÉ almost 8 years ago

  • Pull Request deleted (https://github.com/Normation/rudder-techniques/pull/159)

Actually there is an error in reporting : Ports and Address insertion are fighting each other. so they are always in repaired state :

This is because CFEngine tries to insert lines at the end of file.

Here is an explanation

1- Before port insertion :

port x
address y

2- Remove all ports :

address y

3- insert ports again :

address y
port x

Because the line hase moved CFEngine send a repaired report

The same thing happen right after with addresses sending another repaired report.

and we get back the first situation :

port x
address y

After all this, since we thing the config has changed, ssh service is restarted, and this wrong.

But Jon and I, we may a found a way to handle it : instead of deleting all lines we should only delete line that should not be here.

As we know what ports/addresses we wand we know which line to delete.

To achieve this, we should use a bundle delete_select in delete_line promise => see https://cfengine.com/manuals/cf3-Reference#delete_005fselect-in-delete_005flines

delete_if_not_match_from_list should make it!

Actions #7

Updated by Nicolas PERRON over 7 years ago

  • Status changed from Pending technical review to Discussion

This is no more in Technical Review....

Actions #8

Updated by Jonathan CLARKE over 7 years ago

  • Assignee changed from Jonathan CLARKE to Matthieu CERDA

This approach involves using a not so common feature in CFEngine. It's one for Matthieu.

The idea is to make a list of all valid lines and delete the others by selecting those that don't match the list.

Actions #9

Updated by Nicolas PERRON over 7 years ago

  • Target version changed from 2.4.8 to 2.4.9
Actions #10

Updated by Nicolas PERRON over 7 years ago

  • Target version changed from 2.4.9 to 2.4.10
Actions #11

Updated by Nicolas PERRON over 7 years ago

  • Target version changed from 2.4.10 to 2.4.11
Actions #12

Updated by Nicolas PERRON over 7 years ago

  • Target version changed from 2.4.11 to 2.4.12
Actions #13

Updated by Nicolas PERRON over 7 years ago

  • Target version changed from 2.4.12 to 2.4.13
Actions #14

Updated by Nicolas CHARLES over 7 years ago

Rather than removing/adding lines, shouldn't we simply edit the lines, using the bundle edit_line set_config_values ?

Actions #15

Updated by Nicolas CHARLES over 7 years ago

  • Status changed from Discussion to 8
  • Assignee changed from Matthieu CERDA to Nicolas CHARLES

I'm taking over this ticket

Actions #16

Updated by Nicolas CHARLES over 7 years ago

Oh, i'm telling non-sense; we need multiple lines for the address

Actions #17

Updated by Nicolas CHARLES over 7 years ago

  • Target version changed from 2.4.13 to 2.7.7

this versionning is nonsense ! versions are not matching in 2.6 and 2.7 branch.
i'm moving this ticket for 2.7, and create another one for 2.6
However, we need maplist to have a clean behaviour, and it appeared only in CFEngine 3.3, so i can't directly solve it for 2.4

Actions #18

Updated by Nicolas CHARLES over 7 years ago

  • Status changed from 8 to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/243
Actions #19

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 2.7.7 to 2.7.8
Actions #20

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 2.7.8 to 2.8.3

Since 2.7.* is not supported anymore, targeting in 2.8

Actions #21

Updated by Jonathan CLARKE about 7 years ago

  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES

Nicolas CHARLES wrote:

this versionning is nonsense ! versions are not matching in 2.6 and 2.7 branch.

Shouldn't we fix this first?

Actions #22

Updated by Nicolas CHARLES about 7 years ago

  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE

should I backport the 3.0 to rudder 2.6 ?

Actions #23

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 2.8.3 to 2.8.4
Actions #24

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 2.8.4 to 133
Actions #25

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 133 to 2.9.5
Actions #26

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 2.9.5 to 2.9.6
Actions #27

Updated by Jonathan CLARKE almost 7 years ago

  • Target version changed from 2.9.6 to 2.9.7
Actions #28

Updated by Jonathan CLARKE almost 7 years ago

  • Target version changed from 2.9.7 to 150
Actions #29

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 150 to 2.10.4
Actions #30

Updated by Nicolas PERRON almost 7 years ago

  • Target version changed from 2.10.4 to 2.10.5
Actions #31

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 2.10.5 to 2.10.6
Actions #32

Updated by Matthieu CERDA over 6 years ago

  • Target version changed from 2.10.6 to 2.10.7
Actions #33

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 2.10.7 to 2.10.8
Actions #34

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 2.10.8 to 2.10.9
Actions #35

Updated by François ARMAND over 6 years ago

  • Status changed from Pending technical review to In progress
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES

There is feedback to address in the PR.

Actions #36

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 2.10.9 to 2.10.10
Actions #37

Updated by François ARMAND over 6 years ago

  • Status changed from In progress to Discussion

Nicolas, Benoit, other: could you sum up the status and decide on what to do for that one? We can't let pull request rote like that.

Actions #38

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 2.10.10 to 2.10.11
Actions #39

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 2.10.11 to 2.10.12
Actions #40

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 2.10.12 to 2.10.13
Actions #41

Updated by Benoît PECCATTE about 6 years ago

  • Tracker changed from 5 to User story
Actions #42

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 2.10.13 to 2.10.14
Actions #43

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 2.10.14 to 2.10.15
Actions #44

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 2.10.15 to 2.10.16
Actions #45

Updated by Nicolas CHARLES almost 6 years ago

  • Target version changed from 2.10.16 to 2.11.13

2.10 is old stable, so won't receive this change

Actions #46

Updated by Nicolas CHARLES almost 6 years ago

  • Status changed from Discussion to Pending technical review
  • Assignee changed from Nicolas CHARLES to Matthieu CERDA
  • Pull Request changed from https://github.com/Normation/rudder-techniques/pull/243 to https://github.com/Normation/rudder-techniques/pull/717/commits
Actions #47

Updated by Nicolas CHARLES almost 6 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #48

Updated by François ARMAND over 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.13, 3.0.8 and 3.1.1 which were released today.

Actions

Also available in: Atom PDF