Rudder

The pull request was done on branch 2.6, as this is based on sshConfiguration V2.0 which only exists in 2.6

Since there is a version 3.0 of sshCOnfiguration in 2.7.0, i'll make a new version based on 3.0 including listen addresses

new pull request here : https://github.com/Normation/rudder-techniques/pull/159

Closing the other one : https://github.com/Normation/rudder-techniques/pull/141

Actually there is an error in reporting : Ports and Address insertion are fighting each other. so they are always in repaired state :

This is because CFEngine tries to insert lines at the end of file.

Here is an explanation

1- Before port insertion :

port x
address y

2- Remove all ports :

address y

3- insert ports again :

address y
port x

Because the line hase moved CFEngine send a repaired report

The same thing happen right after with addresses sending another repaired report.

and we get back the first situation :

port x
address y

After all this, since we thing the config has changed, ssh service is restarted, and this wrong.

But Jon and I, we may a found a way to handle it : instead of deleting all lines we should only delete line that should not be here.

As we know what ports/addresses we wand we know which line to delete.

To achieve this, we should use a bundle delete_select in delete_line promise => see https://cfengine.com/manuals/cf3-Reference#delete_005fselect-in-delete_005flines

delete_if_not_match_from_list should make it!

This is no more in Technical Review....

This approach involves using a not so common feature in CFEngine. It's one for Matthieu.

The idea is to make a list of all valid lines and delete the others by selecting those that don't match the list.

I'm taking over this ticket

this versionning is nonsense ! versions are not matching in 2.6 and 2.7 branch.
i'm moving this ticket for 2.7, and create another one for 2.6
However, we need maplist to have a clean behaviour, and it appeared only in CFEngine 3.3, so i can't directly solve it for 2.4

Pull request is there
https://github.com/Normation/rudder-techniques/pull/243

but please merge first the pr of ticket #4190 which is https://github.com/Normation/rudder-techniques/pull/244

Since 2.7.* is not supported anymore, targeting in 2.8

Nicolas CHARLES wrote:

this versionning is nonsense ! versions are not matching in 2.6 and 2.7 branch.

Shouldn't we fix this first?

should I backport the 3.0 to rudder 2.6 ?

There is feedback to address in the PR.

Nicolas, Benoit, other: could you sum up the status and decide on what to do for that one? We can't let pull request rote like that.

2.10 is old stable, so won't receive this change

https://github.com/Normation/rudder-techniques/pull/717/commits

It contains also the fixes of http://www.rudder-project.org/redmine/issues/6945 and http://www.rudder-project.org/redmine/issues/6942 :)

Applied in changeset rudder-techniques|68f446c55d813925a5f416bdefd943231e349b51.

This bug has been fixed in Rudder 2.11.13, 3.0.8 and 3.1.1 which were released today.

• 2.11 3.0 3.1
• 2.11 3.0 3.1
• Download information: https://www.rudder-project.org/site/get-rudder/downloads/