User story #3664
closedUser story #3647: Techhnique "OpenSSH Server": Add possibilty to set ListenAddress
openssh techniques: add possibility to listen address
Added by Vincent MEMBRÉ almost 11 years ago. Updated over 8 years ago.
Description
I will make a pull request from the diff sent by Dennis, and will make any corrections needed before being integrated to Rudder
Files
sshConfiguration.diff (5.98 KB) sshConfiguration.diff | original patch from Dennis Cabooter | Vincent MEMBRÉ, 2013-06-21 10:16 |
Updated by Vincent MEMBRÉ almost 11 years ago
- Tracker changed from Bug to Enhancement
- Status changed from In progress to 10
- Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
- Target version changed from 2.4.7 to 2.6.3
- Pull Request set to https://github.com/Normation/rudder-techniques/pull/141
The pull request was done on branch 2.6, as this is based on sshConfiguration V2.0 which only exists in 2.6
Updated by Nicolas PERRON over 10 years ago
- Target version changed from 2.6.3 to 2.6.4
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from 10 to In progress
- Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
- Target version changed from 2.6.4 to 2.7.0
Since there is a version 3.0 of sshCOnfiguration in 2.7.0, i'll make a new version based on 3.0 including listen addresses
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from In progress to 10
- Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
- Pull Request changed from https://github.com/Normation/rudder-techniques/pull/141 to https://github.com/Normation/rudder-techniques/pull/159
new pull request here : https://github.com/Normation/rudder-techniques/pull/159
Closing the other one : https://github.com/Normation/rudder-techniques/pull/141
Updated by Jonathan CLARKE over 10 years ago
- Status changed from 10 to Pending technical review
- Target version changed from 2.7.0 to 2.4.8
Updated by Vincent MEMBRÉ over 10 years ago
- Pull Request deleted (
https://github.com/Normation/rudder-techniques/pull/159)
Actually there is an error in reporting : Ports and Address insertion are fighting each other. so they are always in repaired state :
This is because CFEngine tries to insert lines at the end of file.
Here is an explanation
1- Before port insertion :
port x address y
2- Remove all ports :
address y
3- insert ports again :
address y port x
Because the line hase moved CFEngine send a repaired report
The same thing happen right after with addresses sending another repaired report.
and we get back the first situation :
port x address y
After all this, since we thing the config has changed, ssh service is restarted, and this wrong.
But Jon and I, we may a found a way to handle it : instead of deleting all lines we should only delete line that should not be here.
As we know what ports/addresses we wand we know which line to delete.
To achieve this, we should use a bundle delete_select in delete_line promise => see https://cfengine.com/manuals/cf3-Reference#delete_005fselect-in-delete_005flines
delete_if_not_match_from_list should make it!
Updated by Nicolas PERRON over 10 years ago
- Status changed from Pending technical review to Discussion
This is no more in Technical Review....
Updated by Jonathan CLARKE over 10 years ago
- Assignee changed from Jonathan CLARKE to Matthieu CERDA
This approach involves using a not so common feature in CFEngine. It's one for Matthieu.
The idea is to make a list of all valid lines and delete the others by selecting those that don't match the list.
Updated by Nicolas PERRON over 10 years ago
- Target version changed from 2.4.8 to 2.4.9
Updated by Nicolas PERRON over 10 years ago
- Target version changed from 2.4.9 to 2.4.10
Updated by Nicolas PERRON over 10 years ago
- Target version changed from 2.4.10 to 2.4.11
Updated by Nicolas PERRON over 10 years ago
- Target version changed from 2.4.11 to 2.4.12
Updated by Nicolas PERRON over 10 years ago
- Target version changed from 2.4.12 to 2.4.13
Updated by Nicolas CHARLES over 10 years ago
Rather than removing/adding lines, shouldn't we simply edit the lines, using the bundle edit_line set_config_values ?
Updated by Nicolas CHARLES over 10 years ago
- Status changed from Discussion to 8
- Assignee changed from Matthieu CERDA to Nicolas CHARLES
I'm taking over this ticket
Updated by Nicolas CHARLES over 10 years ago
Oh, i'm telling non-sense; we need multiple lines for the address
Updated by Nicolas CHARLES over 10 years ago
- Target version changed from 2.4.13 to 2.7.7
this versionning is nonsense ! versions are not matching in 2.6 and 2.7 branch.
i'm moving this ticket for 2.7, and create another one for 2.6
However, we need maplist to have a clean behaviour, and it appeared only in CFEngine 3.3, so i can't directly solve it for 2.4
Updated by Nicolas CHARLES over 10 years ago
- Status changed from 8 to Pending technical review
- Assignee changed from Nicolas CHARLES to Jonathan CLARKE
- Pull Request set to https://github.com/Normation/rudder-techniques/pull/243
Pull request is there
https://github.com/Normation/rudder-techniques/pull/243
but please merge first the pr of ticket #4190 which is https://github.com/Normation/rudder-techniques/pull/244
Updated by Vincent MEMBRÉ about 10 years ago
- Target version changed from 2.7.7 to 2.7.8
Updated by Vincent MEMBRÉ about 10 years ago
- Target version changed from 2.7.8 to 2.8.3
Since 2.7.* is not supported anymore, targeting in 2.8
Updated by Jonathan CLARKE about 10 years ago
- Assignee changed from Jonathan CLARKE to Nicolas CHARLES
Nicolas CHARLES wrote:
this versionning is nonsense ! versions are not matching in 2.6 and 2.7 branch.
Shouldn't we fix this first?
Updated by Nicolas CHARLES about 10 years ago
- Assignee changed from Nicolas CHARLES to Jonathan CLARKE
should I backport the 3.0 to rudder 2.6 ?
Updated by Vincent MEMBRÉ about 10 years ago
- Target version changed from 2.8.3 to 2.8.4
Updated by Vincent MEMBRÉ about 10 years ago
- Target version changed from 2.8.4 to 133
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 133 to 2.9.5
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.9.5 to 2.9.6
Updated by Jonathan CLARKE almost 10 years ago
- Target version changed from 2.9.6 to 2.9.7
Updated by Jonathan CLARKE almost 10 years ago
- Target version changed from 2.9.7 to 150
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 150 to 2.10.4
Updated by Nicolas PERRON over 9 years ago
- Target version changed from 2.10.4 to 2.10.5
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.10.5 to 2.10.6
Updated by Matthieu CERDA over 9 years ago
- Target version changed from 2.10.6 to 2.10.7
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.10.7 to 2.10.8
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.10.8 to 2.10.9
Updated by François ARMAND about 9 years ago
- Status changed from Pending technical review to In progress
- Assignee changed from Jonathan CLARKE to Nicolas CHARLES
There is feedback to address in the PR.
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.10.9 to 2.10.10
Updated by François ARMAND about 9 years ago
- Status changed from In progress to Discussion
Nicolas, Benoit, other: could you sum up the status and decide on what to do for that one? We can't let pull request rote like that.
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.10.10 to 2.10.11
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.10.11 to 2.10.12
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.10.12 to 2.10.13
Updated by Benoît PECCATTE almost 9 years ago
- Tracker changed from Enhancement to User story
Updated by Vincent MEMBRÉ almost 9 years ago
- Target version changed from 2.10.13 to 2.10.14
Updated by Vincent MEMBRÉ almost 9 years ago
- Target version changed from 2.10.14 to 2.10.15
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 2.10.15 to 2.10.16
Updated by Nicolas CHARLES over 8 years ago
- Target version changed from 2.10.16 to 2.11.13
2.10 is old stable, so won't receive this change
Updated by Nicolas CHARLES over 8 years ago
- Status changed from Discussion to Pending technical review
- Assignee changed from Nicolas CHARLES to Matthieu CERDA
- Pull Request changed from https://github.com/Normation/rudder-techniques/pull/243 to https://github.com/Normation/rudder-techniques/pull/717/commits
Updated by Nicolas CHARLES over 8 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset rudder-techniques|68f446c55d813925a5f416bdefd943231e349b51.
Updated by François ARMAND over 8 years ago
- Status changed from Pending release to Released