Rudder

Following #3967, We found out that Scala XML library has some issue with some particular character:

• it correctly refuse invalid characters, throwing an error both when serializing and loading it

val s = <xml>{\u000B}</xml>
<console>:1: error: illegal character '\u000b'
val s = <xml>{\u000B}</xml>
                   ^

• but there is issue with control characters (\r ...)
  • it is some valid xml http://www.w3.org/TR/xml/#charsets
  • correctly accepted withn scala xml

scala> val s = <xml>{"a \rb"}</xml>
b</xml>a.xml.Elem = <xml>a 

• replaced by \n when using loaded from a file (which is an accepted behavior :see first note here: www.w3.org/TR/xml/#sec-common-syn):

scala> val is = new ByteArrayInputStream(s.toString.getBytes)
is: java.io.ByteArrayInputStream = java.io.ByteArrayInputStream@f608fcd

scala> XML.load(is)
res13: scala.xml.Elem = 
<xml>a 
b</xml>

• causing a difference between the initial xml and the one read

scala> res13 == s
res14: Boolean = false

This is causing some issue to us: datas missing in xml, non valid change requests, various security issues...

There is three places in Rudder that serialize dtas into xml:
- Change request (various bug detected, due to comparison between postgres and LDAP datas)
- Events logs
- archive/rollback/datas stored in configuration repository