Project

General

Profile

Actions

User story #4201

closed

User story #4199: Addition of "Technique with values" in Rudder - ncf integration

Adapt expected reports generation to use provided expected report CSV template

Added by François ARMAND almost 11 years ago. Updated over 9 years ago.

Status:
Released
Priority:
1 (highest)
Category:
Web - Compliance & node report
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

For new Technique, we provide a template of expected reports in the mean of a CSV file.

That file miss generation-time information, like Rule UUID and serial, and Directive UUID. So the expected report build process need to be adapt to parse the CSV template, update missing information, and write the resulting files at the expected place.

TODO:

  • define the CSV template name, and its place (=> expected_report_template.csv)
  • define the tag name to be replace for serial, rule UUID, directive UUID (=> @RUDDER_ID@ )
  • define the final CSV path (=> expected_report.csv)

Note: the written CSV must retain all information contained in the source template CSV, especially comments (line starting with #) or headers, if provided.

Actions #1

Updated by François ARMAND almost 11 years ago

  • Description updated (diff)
Actions #2

Updated by François ARMAND almost 11 years ago

  • Assignee set to Nicolas CHARLES

Nico, I belevieve you already worked on that?

Actions #3

Updated by Nicolas CHARLES almost 11 years ago

yeah, but it was on a list of string and not an exact representation of a csv, not with tags (and even less 3 tags as we don't have the rule/directive concepts in cf-clerk)
And all objects are not the final one

The code is there :
https://github.com/ncharles/cf-clerk/tree/ncf

Actions #4

Updated by Nicolas CHARLES almost 11 years ago

  • Status changed from 8 to In progress
Actions #5

Updated by Nicolas CHARLES almost 11 years ago

  • Status changed from In progress to 8

actually, it wasn't on this one I was working on

Actions #6

Updated by Nicolas CHARLES almost 11 years ago

The source file should be in the same folder as the metadata.xml, with the name reports.csv
The tag to replace is RUDDER_ID since we cannot have the split of rule/directive/serial in cfclerk (it doesn't have any meaning there)

the final csv file will be in the root of the directory with the promises (effectively, /var/rudder/cfengine-community/inputs once the promises are copied), with the name reports.csv

Actions #7

Updated by Nicolas CHARLES almost 11 years ago

  • Status changed from 8 to 10
  • Pull Request set to https://github.com/Normation/cf-clerk/pull/27
Actions #8

Updated by Nicolas CHARLES almost 11 years ago

PR updated
The tag name is @RUDDER_ID@
The source name for the csv is expected_reports.csv
The destination file générated by rudder is rudder_expected_reports.csv

Actions #9

Updated by François ARMAND almost 11 years ago

  • Description updated (diff)
  • Pull Request changed from https://github.com/Normation/cf-clerk/pull/27 to https://github.com/Normation/cf-clerk/pull/28
Actions #10

Updated by Nicolas CHARLES almost 11 years ago

  • Status changed from 10 to Pending release
  • % Done changed from 0 to 100

Applied in changeset clerk:commit:4c83a417a4de6f5f48773b2a1b87a4a934b8a9aa.

Actions #11

Updated by Vincent MEMBRÉ almost 11 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.9.0~rc1, which was released on Friday 13/12/2013.
Check out:

Actions #12

Updated by Benoît PECCATTE over 9 years ago

  • Tracker changed from Enhancement to User story
Actions

Also available in: Atom PDF