Project

General

Profile

Actions
Copy link

Bug #4359

closed

It is overly slow to show the list of Pending Review or Pending Deployment even if the number is 0

Added by Nicolas PERRON almost 11 years ago. Updated almost 10 years ago.

Status:
Released
Priority:
1 (highest)
Assignee:
François ARMAND
Category:
Web - Maintenance
Target version:
2.10.10
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

It seems that the request to show the list of the pending review or pending deployment list is not optimal. In fact, it seems that the request is to do a SELECT on all the existing Pending Review/Deployement before to show the open or the closed one.
Then when we just want to go to the only one Pending Review, we can wait for several minutes which is hard to wait when we met #4357/

Related issues 4 (0 open — 4 closed)

Related to Rudder - Bug #4357: Editing a Directive, after creating/cloning, does not show the workflow popup nor redirect to the change requestReleasedFrançois ARMAND2014-01-14Actions
Related to Rudder - Bug #6133: Performance of RuleCategory repository requests are badReleasedNicolas CHARLES2015-01-15Actions
Related to Rudder - Bug #5373: This is very slow to access a change request by URLRejectedActions
Related to Change validation - Bug #4558: Display of change request page is really slowRejectedActions
Actions
Copy link
 #1

Updated by Vincent MEMBRÉ almost 11 years ago

  • Target version changed from 2.6.10 to 2.6.11
Actions
Copy link
 #2

Updated by Vincent MEMBRÉ almost 11 years ago

  • Target version changed from 2.6.11 to 2.6.12
Actions
Copy link
 #3

Updated by Vincent MEMBRÉ almost 11 years ago

  • Target version changed from 2.6.12 to 2.6.13
Actions
Copy link
 #4

Updated by Nicolas CHARLES almost 11 years ago

When we display the change request, we perform the following tasks:!
We get all the change request, and then, for each of them, we:
  1. get the status of this CR in the workflow table
  2. get the latest event linked to this CR to fetch the last action date
  3. get the latest event linked to the related Workflow to fetch the last action date

This is quite inneficient, as we perform 3 queries per CR, with XML searches.

Actions
Copy link
 #5

Updated by Vincent MEMBRÉ over 10 years ago

  • Target version changed from 2.6.13 to 2.6.14
Actions
Copy link
 #6

Updated by Jonathan CLARKE over 10 years ago

  • Target version changed from 2.6.14 to 2.6.16
Actions
Copy link
 #7

Updated by Jonathan CLARKE over 10 years ago

  • Target version changed from 2.6.16 to 2.6.17
Actions
Copy link
 #8

Updated by Nicolas PERRON over 10 years ago

  • Target version changed from 2.6.17 to 2.6.18
Actions
Copy link
 #9

Updated by Matthieu CERDA about 10 years ago

  • Target version changed from 2.6.18 to 2.6.19
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 2.6.19 to 2.6.20
Actions
Copy link
 #11

Updated by Nicolas CHARLES almost 10 years ago

  • Status changed from New to 8
  • Assignee set to François ARMAND
  • Target version changed from 2.6.20 to 2.10.9

This ticket deserves some love !

With more that 4000 change request in the base, the page takes more than 5 minutes to display !
We could clearly improve the backend to perform a lot less queries than that

Assigning to Francois so that he can triage to the right person

Actions
Copy link
 #12

Updated by Vincent MEMBRÉ almost 10 years ago

  • Assignee changed from François ARMAND to Vincent MEMBRÉ

Main reason is that we are making two requests per ChangeRequest to get:

  • Current workflow step
  • Last modification date

Making 10k requests for 500 change requests ...

We should do only 3 requests (all steps, all last modification)

Actions
Copy link
 #13

Updated by Vincent MEMBRÉ almost 10 years ago

  • Status changed from 8 to Pending technical review
  • Pull Request set to https://github.com/Normation/rudder/pull/778
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ almost 10 years ago

  • Status changed from Pending technical review to In progress

Work in progress

Actions
Copy link
 #15

Updated by Vincent MEMBRÉ almost 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions
Copy link
 #16

Updated by Vincent MEMBRÉ almost 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions
Copy link
 #18

Updated by Vincent MEMBRÉ almost 10 years ago

  • Target version changed from 2.10.9 to 2.10.10
Actions
Copy link
 #19

Updated by Vincent MEMBRÉ almost 10 years ago

  • Category changed from Web - UI & UX to Web - Maintenance
Actions
Copy link
 #20

Updated by Vincent MEMBRÉ almost 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.10 and 2.11.7, which were these days.

Actions
Copy link
 #21

Updated by Nicolas CHARLES over 5 years ago

  • Related to Bug #5373: This is very slow to access a change request by URL added
Actions
Copy link
 #22

Updated by Nicolas CHARLES over 5 years ago

  • Related to Bug #4558: Display of change request page is really slow added
Actions
Copy link

Also available in: Atom PDF