Bug #4359
closed
It is overly slow to show the list of Pending Review or Pending Deployment even if the number is 0
Added by Nicolas PERRON almost 11 years ago.
Updated almost 10 years ago.
Category:
Web - Maintenance
Description
It seems that the request to show the list of the pending review or pending deployment list is not optimal. In fact, it seems that the request is to do a SELECT on all the existing Pending Review/Deployement before to show the open or the closed one.
Then when we just want to go to the only one Pending Review, we can wait for several minutes which is hard to wait when we met #4357/
- Target version changed from 2.6.10 to 2.6.11
- Target version changed from 2.6.11 to 2.6.12
- Target version changed from 2.6.12 to 2.6.13
When we display the change request, we perform the following tasks:!
We get all the change request, and then, for each of them, we:
- get the status of this CR in the workflow table
- get the latest event linked to this CR to fetch the last action date
- get the latest event linked to the related Workflow to fetch the last action date
This is quite inneficient, as we perform 3 queries per CR, with XML searches.
- Target version changed from 2.6.13 to 2.6.14
- Target version changed from 2.6.14 to 2.6.16
- Target version changed from 2.6.16 to 2.6.17
- Target version changed from 2.6.17 to 2.6.18
- Target version changed from 2.6.18 to 2.6.19
- Target version changed from 2.6.19 to 2.6.20
- Status changed from New to 8
- Assignee set to François ARMAND
- Target version changed from 2.6.20 to 2.10.9
This ticket deserves some love !
With more that 4000 change request in the base, the page takes more than 5 minutes to display !
We could clearly improve the backend to perform a lot less queries than that
Assigning to Francois so that he can triage to the right person
- Assignee changed from François ARMAND to Vincent MEMBRÉ
Main reason is that we are making two requests per ChangeRequest to get:
- Current workflow step
- Last modification date
Making 10k requests for 500 change requests ...
We should do only 3 requests (all steps, all last modification)
- Status changed from 8 to Pending technical review
- Pull Request set to https://github.com/Normation/rudder/pull/778
- Status changed from Pending technical review to In progress
- Status changed from In progress to Pending technical review
- Assignee changed from Vincent MEMBRÉ to François ARMAND
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
- Target version changed from 2.10.9 to 2.10.10
- Category changed from Web - UI & UX to Web - Maintenance
- Status changed from Pending release to Released
This bug has been fixed in Rudder 2.10.10 and 2.11.7, which were these days.
- Related to Bug #5373: This is very slow to access a change request by URL added
- Related to Bug #4558: Display of change request page is really slow added
Also available in: Atom
PDF