Bug #4687
closedUser story #4595: Support for AIX (agent only)
User story #4671: Avoid listing files twice in .spec %files section
missing files in rudder-agent packages, missing symlinks
Description
the option "-o -type s" does not take the symlink files into account.
using -L instead will work:
on both sles10 and rhel5
Installed (but unpackaged) file(s) found: /opt/rudder/lib/libtokyocabinet.so /opt/rudder/lib/libtokyocabinet.so.9
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from New to Pending technical review
- Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
- Pull Request set to https://github.com/Normation/rudder-packages/pull/284
Updated by François ARMAND over 10 years ago
The question I was wondering is "do we want 1/ (-L + -type f) or do we want 2/ (-type f - o -type l)
(The -type s was clearly an error, as it's type "socket").
In case 1/ I'm saying "I want symling which points toward files (and files)". In 2/, I'm saying "I want files, and symlink, whatever they point to".
I believe we don't want symling pointing toward directories. But we want all files, even if they are under a sylinked directory. So we want 1/
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset commit:9228431aeaf490f02f33bb93a92646c41bbd6f1a.
Updated by François ARMAND over 10 years ago
Applied in changeset commit:760e61a5552129f997d89fdf4d01527cfd430c4a.
Updated by François ARMAND over 10 years ago
Example:
== [fanf@luhman16] /tmp/test == % tree . |-- a.link -> a.plop |-- a.plop |-- foo | `-- b.plop `-- foo.link -> foo 2 directories, 3 files == [fanf@luhman16] /tmp/test == % find . -type f -o -type l ./a.plop ./a.link ./foo/b.plop ./foo.link == [fanf@luhman16] /tmp/test == % find -L . -type f ./a.plop ./a.link ./foo/b.plop ./foo.link/b.plop <pre> I really don't think we want "foo.link" ever, but we want "foo.link/b.plop".
Updated by Jonathan CLARKE over 10 years ago
- Status changed from Pending release to Discussion
- Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
The currently implemented approach is wrong. What we want is what François described as "2/ (-type f - o -type l)".
We must package links as links, not as whatever they point to. Imagine a symlink to /etc - we should absolutely not follow it, and package the contents of /etc from the build machine!
Please revert this and use the "-type f - o -type l" variant instead of -L.
Updated by Vincent MEMBRÉ over 10 years ago
- Pull Request changed from https://github.com/Normation/rudder-packages/pull/284 to https://github.com/Normation/rudder-packages/pull/286
corrected here: https://github.com/Normation/rudder-packages/pull/286
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from Discussion to Pending technical review
- Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset commit:310c8a1bba4065bf93c13c964e6e99e50f50eb99.
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 2.10.0, which was released today.
Check out:
- The release announcement: http://www.rudder-project.org/pipermail/rudder-announce/2014-March/000085.html
- The full ChangeLog: http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog210
- Download information: https://www.rudder-project.org/site/get-rudder/downloads/