Project

General

Profile

Actions

Bug #4719

closed

Technique sshKeyDistribution: ssh keys are not added or replaced if they don't finish by equal sign

Added by William Ott over 10 years ago. Updated over 10 years ago.

Status:
Released
Priority:
2
Assignee:
Jonathan CLARKE
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

There seems to be a problem with the edit_line bundle append_or_replace_ssh_key, because the authorized_key file is being created and the permissions are set but no line is either inserted or replaced.

Actions #1

Updated by François ARMAND over 10 years ago

  • Status changed from New to 8
  • Assignee set to Nicolas CHARLES
  • Priority changed from N/A to 1 (highest)

Thanks for the report !

Nicolas, or Matthieu, could you look to that ?

Actions #2

Updated by Nicolas CHARLES over 10 years ago

I confirm, this doesn't do as expected.
The code is too complex for me to fix it tonight thought, there are bad things going on with classes and vars (and not respecting normal ordering)

Actions #3

Updated by Nicolas CHARLES over 10 years ago

  • Subject changed from sshKeyDistribution 2.0 technique not appending or replacing ssh keys to sshKeyDistribution 2.0 technique not appending or replacing ssh keys when they don't finish by equal sign

I updated the title of the ticket

This technique enforces that the key should finish by = sign, otherwise it doesn't add it. Hoewever there is no reason for that (RFC doesn't state that it should finish by = , see http://tools.ietf.org/html/rfc4716 )

Actions #4

Updated by Nicolas CHARLES over 10 years ago

  • Category changed from System techniques to Techniques
  • Status changed from 8 to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/374
Actions #5

Updated by Vincent MEMBRÉ over 10 years ago

  • Target version changed from 2.9.5 to 2.9.6
Actions #6

Updated by Nicolas CHARLES over 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset policy-templates:commit:bccfbffe10e118128a1b75070bd6d2fba01fd535.

Actions #7

Updated by Jonathan CLARKE over 10 years ago

  • Priority changed from 1 (highest) to 2
Actions #8

Updated by Vincent MEMBRÉ over 10 years ago

  • Subject changed from sshKeyDistribution 2.0 technique not appending or replacing ssh keys when they don't finish by equal sign to Technique sshKeyDistribution: ssh keys are not added or replaced if they don't finish by equal sign
Actions #9

Updated by Vincent MEMBRÉ over 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder versions that were released today.

Actions

Also available in: Atom PDF