Bug #5397: The file_from_template generic method can not use mustache templates on pre-3.6 CFEngine - Rudder - Issue Tracker

Custom queries

8.1 beta
Bugs triage
CS - by priority
CS - to review
My TR
Need technical review
Open bugs (all)
Open bugs (UI - UX)
Open UX defects (all)
Opened by users

Actions

Copy link

Bug #5397

closed

The file_from_template generic method can not use mustache templates on pre-3.6 CFEngine

Added by Matthieu CERDA over 10 years ago. Updated over 2 years ago.

Status:

Released

Priority:

N/A

Assignee:

Jonathan CLARKE

Category:

Generic methods

Target version:

ncf-0.x

Pull Request:

https://github.com/Normation/ncf/pull...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

If the current ncf version is used on pre-3.6 CFEngine versions, it fails as the template_method attribute does not exist yet.

We should offer a way to offer this method without breaking old CFEngines!

Subtasks 4 (0 open — 4 closed)

Bug #5401: Create a shell script that list all .cf files compatible with a given cf-agent version.	Released	Benoît PECCATTE	Actions
Bug #5403: F is not a posix sed command	Released	Jonathan CLARKE	Actions
Bug #5404: Script must return full path	Rejected	Benoît PECCATTE	Actions
Bug #5423: Tests don't work on CFengine 3.5	Rejected		Actions

Related issues 2 (0 open — 2 closed)

	Related to Rudder - Bug #5402: Agent can't run because some ncf promises are CFEngine 3.6 specific	Released	Jonathan CLARKE	2014-08-19			Actions
	Related to Rudder - Bug #5409: Fisrt promise generation fail on Rudder server ( /var/rudder/ncf/local missing)	Released	Jonathan CLARKE	2014-08-19			Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by Matthieu CERDA over 10 years ago

Note, a workaround exists to solve the problem temporary until it is fixed upstream:

rm /usr/share/ncf/tree/30_generic_methods/file_from_template*
rm /var/rudder/ncf/common/30_generic_methods/file_from_template*
curl https://raw.githubusercontent.com/Normation/ncf/0efb9eb11191fdf31ebb6fba1f4c3a338d925e45/tree/30_generic_methods/file_from_template.cf > /usr/share/ncf/tree/30_generic_methods/file_from_template.cf
cp /usr/share/ncf/tree/30_generic_methods/file_from_template.cf /var/rudder/ncf/common/30_generic_methods/

Actions

Copy link

Updated by Benoît PECCATTE over 10 years ago

Status changed from 8 to In progress
Target version set to 0.x

First define a new optional attribute to ncf bundles: @agent_version that defines the agent version compatible with this bundle. Currently only >=x.y will be supported.

Then create a shell script that list all .cf files compatible with a given cf-agent version.
This script will be used in body common control to include compatible methods only.

Finally rewrite file_from_template_* to separate 3.5 version and 3.6 version (with mustache suport) and add @agent_version to them.

Actions

Copy link