Project

General

Profile

Actions

Bug #5465

closed

We should not canonify ourselves class context given in ncf

Added by Vincent MEMBRÉ about 8 years ago. Updated 4 months ago.

Status:
Released
Priority:
1
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

entries in ncf are canonified manualy ( replace \W by _) this replace variable added in by ncf

package_install_${apache.package.name} => package_install__apache_package_name_

We should remove that part, and surround the class by the canonify function:

canonify("package_install_${apache.package.name}");

But we don't want to add a canonify if the class didn't need it

The following class:

suse.debian

should stay lke this


Subtasks 2 (0 open2 closed)

Bug #5466: Canonified classes are not properly displayedRejectedActions
Bug #6275: Fix negative status and test when a variable is used in class contextReleasedVincent MEMBRÉActions

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #5558: When we use variables in parameters, for a generic methods that have a condition, the resulting generated not applicable file is invalidReleasedJonathan CLARKEActions
Actions #1

Updated by Nicolas CHARLES about 8 years ago

I tried to use canonify, and it failed (at least if we are speaking of the logger_rudder)
You cannot use (anymore?, i think it used before), canonify as an arguement of function; so I cannot use it in the class_noop condition, unless defining an unholy number of variable first with a logical naming scheme (preventing duplicate), and using them in the call to class_noop, and still maintain everything readable.

Actions #2

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from New to In progress
  • Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
  • Target version set to 0.x
Actions #3

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/170
Actions #4

Updated by Benoît PECCATTE over 7 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Benoît PECCATTE to Vincent MEMBRÉ
Actions #5

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from Discussion to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:d3565ffb970f594a946eacb196f9446f18b640c6.

Actions #6

Updated by Benoît PECCATTE over 7 years ago

Applied in changeset commit:5d4b49118025ea1209281a76e72d6b89a3ed7403.

Actions #7

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
Actions #8

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #9

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF