Bug #5465: We should not canonify ourselves class context given in ncf - Rudder - Issue Tracker

Actions

Copy link

Bug #5465

closed

We should not canonify ourselves class context given in ncf

Added by Vincent MEMBRÉ over 10 years ago. Updated over 2 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Vincent MEMBRÉ

Category:

Generic methods

Target version:

ncf-0.x

Pull Request:

https://github.com/Normation/ncf/pull...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

entries in ncf are canonified manualy ( replace \W by _) this replace variable added in by ncf

package_install_${apache.package.name} => package_install__apache_package_name_

We should remove that part, and surround the class by the canonify function:

canonify("package_install_${apache.package.name}");

But we don't want to add a canonify if the class didn't need it

The following class:

suse.debian

should stay lke this

Subtasks 2 (0 open — 2 closed)

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Nicolas CHARLES over 10 years ago

I tried to use canonify, and it failed (at least if we are speaking of the logger_rudder)
You cannot use (anymore?, i think it used before), canonify as an arguement of function; so I cannot use it in the class_noop condition, unless defining an unholy number of variable first with a logical naming scheme (preventing duplicate), and using them in the call to class_noop, and still maintain everything readable.

Actions

Copy link