Bug #5650: promises can become invalid if copies fail rendering the agent unusable - Rudder - Issue Tracker

Actions

Copy link

Bug #5650

closed

promises can become invalid if copies fail rendering the agent unusable

Added by Nicolas CHARLES about 10 years ago. Updated over 2 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Benoît PECCATTE

Category:

System integration

Target version:

2.11.21

Pull Request:

https://github.com/Normation/rudder-p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

When there is no space left on device, inputs may get purge. Or inputs may also get purge if somebody is manually deleting the files in the inputs folder on the node
In this case, the node is in a broken state, and nothing can revive it, unless a manual intervention

We should have a check for the validity of syntax of failsafe.cf, and if invalid, use initial promises to fetch repared promises from the server

Related issues 1 (1 open — 0 closed)

Actions

Copy link

Updated by François ARMAND about 10 years ago

This seems that it can be one of the check of the step 3 of #5641

Actions

Copy link

Updated by Jonathan CLARKE about 10 years ago

Target version set to 3.1.0~beta1

This will be addressed by #5641.

Actions

Copy link

Updated by Florian Heigl over 9 years ago

You could additionaly consider adding a copy of the most basic initial promises (failsafe.cf?) as part of /opt/rudder/bin/rudder-check.

Actions

Copy link

Updated by Vincent MEMBRÉ over 9 years ago

Target version changed from 3.1.0~beta1 to 3.1.0~rc1

Actions

Copy link

Updated by Vincent MEMBRÉ over 9 years ago

Target version changed from 3.1.0~rc1 to 3.1.0

Actions

Copy link

Updated by Vincent MEMBRÉ over 9 years ago

Target version changed from 3.1.0 to 3.1.1

Actions

Copy link

Updated by Vincent MEMBRÉ over 9 years ago

Target version changed from 3.1.1 to 3.1.2

Actions

Copy link

Updated by Vincent MEMBRÉ about 9 years ago

Target version changed from 3.1.2 to 3.1.3

Actions

Copy link

Updated by Vincent MEMBRÉ about 9 years ago

Target version changed from 3.1.3 to 3.1.4

Actions

Copy link

#10

Updated by Vincent MEMBRÉ about 9 years ago

Target version changed from 3.1.4 to 3.1.5

Actions

Copy link

#11

Updated by Vincent MEMBRÉ about 9 years ago

Target version changed from 3.1.5 to 3.1.6

Actions

Copy link

#12

Updated by Vincent MEMBRÉ almost 9 years ago

Target version changed from 3.1.6 to 3.1.7

Actions

Copy link

#13

Updated by Vincent MEMBRÉ almost 9 years ago

Target version changed from 3.1.7 to 3.1.8

Actions

Copy link

#14

Updated by Vincent MEMBRÉ almost 9 years ago

Target version changed from 3.1.8 to 3.1.9

Actions

Copy link

#15

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 3.1.9 to 3.1.10

Actions

Copy link

#16

Updated by Jonathan CLARKE over 8 years ago

Translation missing: en.field_tag_list set to Sponsored, Next minor release, Quick and important
Subject changed from When there is no space left on device, promises files can get deleted, rendering the agent unusable to promises can become invalid if copies fail rendering the agent unusable
Assignee set to Jonathan CLARKE
Priority changed from N/A to 1 (highest)
Target version changed from 3.1.10 to 2.11.21

This can happen in two distinct cases:

The main promises (promises.cf + includes) get broken. An aborted copy can cause this (a new promises.cf gets copies, including a reference to fileX.cf, but the copy stops before fileX.cf is copied, breaking that set of promises)
The backup failsafe.cf can be broken in much rarer cases, like no space left on device, a really bad error in failsafe.cf or update.cf, or possibly neutrino rain (see #5641)

A good, thorough workaround is to implement #5641. A quick and easy workaround is to check for these conditions in check-rudder-agent and fix them.

Actions

Copy link

#17