Actions
Bug #6614
closedUser story #6553: Allow rudder server to remotely run the agent
cf-serverd.cf is broken because of missing promise type
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:
Description
When generating promises on 2.11.11 :
⇨ cf-promise check fails for promises generated at '/var/rudder/share/e19c5e00-4eda-4e97-a58c-07d4c3b30bca.new/rules/cfengine-community' ⇨ /var/rudder/share/e19c5e00-4eda-4e97-a58c-07d4c3b30bca.new/rules/cfengine-community/common/1.0/cf-served.cf:27:9: error: syntax error ⇨ any:: ⇨ ^ ⇨ /var/rudder/share/e19c5e00-4eda-4e97-a58c-07d4c3b30bca.new/rules/cfengine-community/common/1.0/cf-served.cf:27:9: error: Expected promise type, got 'any::' ⇨ any:: ⇨ ^ [...] ⇨ Too many errors
The generated file contains :
bundle server access_rules { any:: # Allow server to remotely run the agent "/var/rudder/cfengine-community/bin/cf-agent" admit => { host2ip("${server_info.cfserved}"), string_downcase(escape("${server_info.cfserved}")) }; roles: # Allow user root to set any class ".*" authorize => { "root" }; }
which lacks the "access" promise type. This appears to be caused by https://github.com/Normation/rudder-techniques/pull/664, the promise type "access" should be moved before &if(CLIENTSLIST)&.
Updated by Alexis Mousset over 9 years ago
- Target version changed from 2.11.11 to 2.10.14
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.10.14 to 2.10.15
Updated by Nicolas CHARLES over 9 years ago
- Status changed from New to Pending technical review
- Assignee set to Alexis Mousset
- Pull Request set to https://github.com/Normation/rudder-techniques/pull/671
Updated by Nicolas CHARLES over 9 years ago
- Assignee changed from Alexis Mousset to Benoît PECCATTE
Benoit, could you have a look at the pr ?
Updated by Nicolas CHARLES over 9 years ago
it also prevent dns lookup when variable is not set !
Updated by Benoît PECCATTE over 9 years ago
- Status changed from Pending technical review to Discussion
- Assignee changed from Benoît PECCATTE to Nicolas CHARLES
Updated by Benoît PECCATTE over 9 years ago
- Status changed from Discussion to In progress
- Assignee changed from Nicolas CHARLES to Benoît PECCATTE
Updated by Benoît PECCATTE over 9 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Benoît PECCATTE to Matthieu CERDA
- Pull Request changed from https://github.com/Normation/rudder-techniques/pull/671 to https://github.com/Normation/rudder-techniques/pull/673
Updated by Benoît PECCATTE over 9 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset rudder-techniques|6b90aec1bab289537ee2111f4d1a068f6db114f2.
Updated by Matthieu CERDA over 9 years ago
Applied in changeset rudder-techniques|72d4c4cfec2fb93c8f28496c03055635da6e5af2.
Updated by Nicolas CHARLES over 9 years ago
- Related to Bug #6624: Merge error in common technique, resulting in invalid code added
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.10.15 to 2.10.14
Updated by Vincent MEMBRÉ over 9 years ago
- Related to deleted (Bug #6624: Merge error in common technique, resulting in invalid code)
Updated by Vincent MEMBRÉ over 9 years ago
- Parent task changed from #6543 to #6553
Updated by Vincent MEMBRÉ over 9 years ago
- Status changed from Pending release to Released
Actions