Bug #6614
closed
User story #6553: Allow rudder server to remotely run the agent
cf-serverd.cf is broken because of missing promise type
Added by Alexis Mousset almost 10 years ago.
Updated almost 10 years ago.
Description
When generating promises on 2.11.11 :
⇨ cf-promise check fails for promises generated at '/var/rudder/share/e19c5e00-4eda-4e97-a58c-07d4c3b30bca.new/rules/cfengine-community'
⇨ /var/rudder/share/e19c5e00-4eda-4e97-a58c-07d4c3b30bca.new/rules/cfengine-community/common/1.0/cf-served.cf:27:9: error: syntax error
⇨ any::
⇨ ^
⇨ /var/rudder/share/e19c5e00-4eda-4e97-a58c-07d4c3b30bca.new/rules/cfengine-community/common/1.0/cf-served.cf:27:9: error: Expected promise type, got 'any::'
⇨ any::
⇨ ^
[...]
⇨ Too many errors
The generated file contains :
bundle server access_rules
{
any::
# Allow server to remotely run the agent
"/var/rudder/cfengine-community/bin/cf-agent"
admit => { host2ip("${server_info.cfserved}"), string_downcase(escape("${server_info.cfserved}")) };
roles:
# Allow user root to set any class
".*" authorize => { "root" };
}
which lacks the "access" promise type. This appears to be caused by https://github.com/Normation/rudder-techniques/pull/664, the promise type "access" should be moved before &if(CLIENTSLIST)&.
- Target version changed from 2.11.11 to 2.10.14
- Target version changed from 2.10.14 to 2.10.15
- Status changed from New to Pending technical review
- Assignee set to Alexis Mousset
- Pull Request set to https://github.com/Normation/rudder-techniques/pull/671
- Assignee changed from Alexis Mousset to Benoît PECCATTE
Benoit, could you have a look at the pr ?
it also prevent dns lookup when variable is not set !
- Status changed from Pending technical review to Discussion
- Assignee changed from Benoît PECCATTE to Nicolas CHARLES
- Status changed from Discussion to In progress
- Assignee changed from Nicolas CHARLES to Benoît PECCATTE
- Status changed from In progress to Pending technical review
- Assignee changed from Benoît PECCATTE to Matthieu CERDA
- Pull Request changed from https://github.com/Normation/rudder-techniques/pull/671 to https://github.com/Normation/rudder-techniques/pull/673
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
- Related to Bug #6624: Merge error in common technique, resulting in invalid code added
- Target version changed from 2.10.15 to 2.10.14
- Related to deleted (Bug #6624: Merge error in common technique, resulting in invalid code)
- Parent task changed from #6543 to #6553
- Status changed from Pending release to Released
This bug has been fixed in Rudder 2.10.14, 2.11.11 and 3.0.5 which were released today.
Also available in: Atom
PDF