Rudder

Clearly that should be changed in the system technique:

Some idea:

If an inventory sending fails for full queue, raise a class "inventory_full_queue" and skip send inventories

Alexis, this should be a quick fix, could you look into it please?

It is not that easy since the classes are not evaluated when iterating over the selected files in the transformer.

I think it works because you iterate over a CFEngine variable, whereas the inventory code uses a file_select. The following example does not stop after failure:

body common control {
  bundlesequence => { "test" };
}

bundle agent test {

vars:
  "names" slist => { "0", "1", "3", "4", "5" };

files:
  # Initialise files
  "/tmp/${names}.test" 
    create => "true",
    edit_defaults => empty,
    edit_line => content("/bin/true");

  "/tmp/2.test" 
    edit_defaults => empty,
    edit_line => content("/bin/false");

  # Now all files contain "/bin/true" except "/tmp/2" which contains "/bin/false" 

  "/tmp" 
    file_select => test_files,
    depth_search => recurse_visible(1),
    ifvarclass  => "!transformer_error",
    transformer => "/bin/bash ${this.promiser}",
    classes     => result("transformer");
}

body depth_search recurse_visible(d)
{
        depth        => "${d}";
        exclude_dirs => { "\..*" };
}

body file_select test_files
{
      leaf_name => { ".*.test" };
      file_result => "leaf_name";
}

body classes result(key) {
  repair_failed => { "${key}_error" };
}

bundle edit_line content(line) {
  insert_lines:
    "${line}";
}

body edit_defaults empty
{
  empty_file_before_editing => "true";
}

    info: Transforming '/bin/bash /tmp/2.test' 
   error: Finished command related to promiser '/tmp' -- an error occurred, returned 1
   error: Transformer '/tmp/2.test' => '/bin/bash /tmp/2.test' returned error
    info: Transforming '/bin/bash /tmp/5.test' 
    info: Transformer '/tmp/5.test' => '/bin/bash /tmp/5.test' seemed to work ok
    info: Transforming '/bin/bash /tmp/4.test' 
    info: Transformer '/tmp/4.test' => '/bin/bash /tmp/4.test' seemed to work ok
    info: Transforming '/bin/bash /tmp/3.test' 
    info: Transformer '/tmp/3.test' => '/bin/bash /tmp/3.test' seemed to work ok
    info: Transforming '/bin/bash /tmp/1.test' 
    info: Transformer '/tmp/1.test' => '/bin/bash /tmp/1.test' seemed to work ok
    info: Transforming '/bin/bash /tmp/0.test' 
    info: Transformer '/tmp/0.test' => '/bin/bash /tmp/0.test' seemed to work ok

Ah, interesting. Thanks for the further analysis.

According to https://github.com/Normation/rudder-techniques/blob/master/techniques/system/distributePolicy/1.0/propagatePromises.st#L193 and https://github.com/Normation/rudder-techniques/blob/master/techniques/system/common/1.0/site.st#L110, the file_select just gets all files that are *.ocs and *.ocs.gz.

Since this works when iterating over a CFEngine variable, let's try and get into the situation where this works. We could get the list of files in a CFEngine variable using the findfiles function (see https://docs.cfengine.com/docs/3.7/reference-functions-findfiles.html), like this:

  "inventory_files" slist => findfiles("${g.rudder_inventories}/incoming/*.ocs", "${g.rudder_inventories}/incoming/*.ocs.gz");

Alexis, could you test this and propose a PR if it works please?

PR https://github.com/Normation/rudder-techniques/pull/905

Applied in changeset rudder-techniques|6e459a2dbe0cc8dd8a6ba55968cb75e4ecfb6269.

This bug has been fixed in Rudder 2.11.20, 3.0.15, 3.1.9 and 3.2.2 which were released today.

• 2.11: Announce Changelog
• 3.0: Announce Changelog
• 3.1: Announce Changelog
• 3.2: Announce Changelog
• Download: https://www.rudder-project.org/site/get-rudder/downloads/