Bug #8628
closed
'ip' fields in techniques/directives does not support ipv6
Added by Janos Mattyasovszky over 8 years ago.
Updated over 7 years ago.
Category:
Web - Config management
Description
Hi,
Currently there is an "ip" type of contraint for the input fields in the metadata.xml, however, there is none for the IPv6 Address format.
Since IPv6 is getting used more and more, it would be highly recommended to have a validated type that accepts ipv6 formats.
EDIT: the implemented solution have three constraints:
<CONSTRAINT><TYPE>ip</TYPE></CONSTRAINT> <!-- accept both ipv4 and ipv6 -->
<CONSTRAINT><TYPE>ipv4</TYPE></CONSTRAINT> <!-- accept ipv4 only -->
<CONSTRAINT><TYPE>ipv6</TYPE></CONSTRAINT> <!-- accept ipv6 only -->
- Category set to Web - Config management
Ha - this is right
ip is currently used in sshConfiguration technique
It only validates ipv4
Should we:
- Make ip validate both ipv4 and ipv6 (could it break something ??)
- Make ip validate only ipv4, and create ipv4 alias, plus ipv6; and create a new type that validate both
- do something else more clever that I don't see ?
how about:
- ip => version 4, not to break anything existing (could also have an ipv4 alias to have it follow the naming schema)
- ipv6 => only version 6
- ip_any => both 4/6
I agree we must continue to support existing installation without change. But I thing that "ip" should match both ipv4 and ipv6, and take a (new) paramter to restrict to one kind.
the rationnal is that people having used "ip" check were not expecting "only ipv4" at the time.
- Tracker changed from User story to Bug
- Assignee changed from Nicolas CHARLES to François ARMAND
- Priority changed from N/A to 2
- Target version set to 3.1.12
- Reproduced set to No
- Target version changed from 3.1.12 to 3.1.13
Agreed. Let's change the "ip" type to handle IPv4 or IPv6, and add "ipv4" and "ipv6" types that match only them.
- Target version changed from 3.1.13 to 3.1.14
- Status changed from New to In progress
- Status changed from In progress to Pending technical review
- Assignee changed from François ARMAND to Vincent MEMBRÉ
- Pull Request set to https://github.com/Normation/cf-clerk/pull/94
- Description updated (diff)
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
- Subject changed from Metadata.xml ipv6 INPUT TYPE constraint to 'ip' fields in techniques/directives does not support ipv6
- Status changed from Pending release to Released
This bug has been fixed in Rudder 3.1.15/14 and 3.2.8/7 which were released today.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by 
Updated by Jonathan CLARKE