Project

General

Profile

Actions

Bug #9087

closed

Error on promises generation when there are no properties files

Added by Nicolas CHARLES over 7 years ago. Updated over 5 years ago.

Status:
Rejected
Priority:
N/A
Assignee:
-
Category:
System techniques
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Infrequent - complex configurations | third party integrations
Effort required:
Small
Priority:
47
Name check:
Fix check:
Regression:

Description

If there are no properties defined, we have the following error at generation:

Command to check generated promises is: '/var/rudder/cfengine-community/bin/cf-promises -f /var/rudder/cfengine-community/inputs.new/promises.cf'
⇨ error: readjson: data error parsing JSON file 'cf_null': No data
⇨ error: readjson: data error parsing JSON file 'cf_null': No data
⇨ error: readjson: data error parsing JSON file 'cf_null': No data

issue is we don't check that there are any files in the findfiles in common/1.0/properties.cf - if folder is empty, then it returns cf_null
This is pretty impacting as when doing update of Rudder, we come from a state with no properties to a state with properties, but we check the previous generated properties (${sys.workdir}/inputs/properties.d/*.json)


Related issues 3 (0 open3 closed)

Related to Rudder - Bug #8756: Expose node properties in properties.d not propertiesReleasedNicolas CHARLES2016-07-26Actions
Related to Rudder - User story #8737: Expose node properties as a global CFEngine data variableReleasedNicolas CHARLES2016-07-26Actions
Has duplicate Rudder - Bug #9106: If properties.d doesn't exists, cf-promises fails with an "error 'cf_null'"Rejected2016-09-22Actions
Actions

Also available in: Atom PDF