Bug #9130: Reporting missing if several generic methods with same class_prefix and different condition applied - Rudder - Issue Tracker

Severity set to Minor - inconvenience | misleading | easy workaround
User visibility set to Operational - other Techniques | Technique editor | Rudder settings
Priority set to 15

Actions

Copy link

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 3.1.19 to 3.1.20

Actions

Copy link

Updated by Jonathan CLARKE over 7 years ago

Status changed from In progress to New

Actions

Copy link

#10

Updated by Jonathan CLARKE over 7 years ago

Assignee deleted (~~François ARMAND~~)

Actions

Copy link

#11

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 3.1.20 to 3.1.21

Actions

Copy link

#12

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 3.1.21 to 3.1.22

Actions

Copy link

#13

Updated by Benoît PECCATTE over 7 years ago

Priority changed from 15 to 28

Actions

Copy link

#14

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 3.1.22 to 3.1.23

Actions

Copy link

#15

Updated by Vincent MEMBRÉ about 7 years ago

Target version changed from 3.1.23 to 3.1.24
Priority changed from 28 to 27

Actions

Copy link

#16

Updated by Vincent MEMBRÉ about 7 years ago

Target version changed from 3.1.24 to 3.1.25

Actions

Copy link

#17

Updated by Vincent MEMBRÉ almost 7 years ago

Target version changed from 3.1.25 to 387

Actions

Copy link

#18

Updated by Vincent MEMBRÉ almost 7 years ago

Target version changed from 387 to 4.1.10

Actions

Copy link

#19

Updated by Vincent MEMBRÉ almost 7 years ago

Target version changed from 4.1.10 to 4.1.11

Actions

Copy link

#20

Updated by Vincent MEMBRÉ over 6 years ago

Target version changed from 4.1.11 to 4.1.12

Actions

Copy link

#21

Updated by Vincent MEMBRÉ over 6 years ago

Target version changed from 4.1.12 to 4.1.13

Actions

Copy link

#22

Updated by Vincent MEMBRÉ over 6 years ago

Target version changed from 4.1.13 to 4.1.14

Actions

Copy link

#23

Updated by Benoît PECCATTE over 6 years ago

Target version changed from 4.1.14 to 4.1.15

Actions

Copy link

#24

Updated by Vincent MEMBRÉ about 6 years ago

Target version changed from 4.1.15 to 4.1.16

Actions

Copy link

#25

Updated by Vincent MEMBRÉ about 6 years ago

Target version changed from 4.1.16 to 4.1.17

Actions

Copy link

#26

Updated by Vincent MEMBRÉ almost 6 years ago

Target version changed from 4.1.17 to 4.1.18
Priority changed from 27 to 0

Actions

Copy link

#27

Updated by Vincent MEMBRÉ almost 6 years ago

Target version changed from 4.1.18 to 4.1.19

Actions

Copy link

#28

Updated by Alexis Mousset almost 6 years ago

Target version changed from 4.1.19 to 4.1.20

Actions

Copy link

#29

Updated by François ARMAND over 5 years ago

Target version changed from 4.1.20 to 4.1.21

Actions

Copy link

#30

Updated by François ARMAND over 5 years ago

Translation missing: en.field_tag_list set to Sponsored, community
Severity changed from Minor - inconvenience | misleading | easy workaround to Major - prevents use of part of Rudder | no simple workaround
User visibility changed from Operational - other Techniques | Technique editor | Rudder settings to Operational - other Techniques | Rudder settings | Plugins
Priority changed from 0 to 70

Actions

Copy link

#31

Updated by Nicolas CHARLES over 5 years ago

Assignee set to Nicolas CHARLES
Target version changed from 4.1.21 to 5.0.9

This is unfixable in 4.1 - testing that it works as expected in 5.0

Actions

Copy link

#32

Updated by Nicolas CHARLES over 5 years ago

so - in 5.0, there is no missing report
However there is a leaking of reporting: the AIX get the same report as the Linux (the class leaks from the generic method to the noop)

Actions

Copy link

#33

Updated by Nicolas CHARLES over 5 years ago

the rudder_reporting.cf doesn't provide enough information to avoid the issue

we could replace

    "promisers"          slist => { @{this.callers_promisers}, cf_null }, policy => "ifdefined";
    "class_prefix"      string => canonify(join("_", "promisers"));
    "args"               slist => { };

by actual information, and set the classes_noop accordingly

Actions

Copy link

#34

Updated by Nicolas CHARLES over 5 years ago

Translation missing: en.field_tag_list changed from Sponsored, community to Sponsored, community, Next minor release

Actions

Copy link

#35

Updated by Nicolas CHARLES over 5 years ago

Translation missing: en.field_tag_list changed from Sponsored, community, Next minor release to Sponsored, community

for the record, a working implementation is:

bundle agent check_class_prefix_rudder_reporting
{
  vars:
    "promisers"          slist => { @{this.callers_promisers}, cf_null }, policy => "ifdefined";
    "class_prefix"      string => "check_class_prefix_rudder_reporting";
    "args"               slist => { };

  methods:

    !(aix)::
      "dummy_report" usebundle => _classes_noop("${class_prefix}_file_present__tmp_test");
      "dummy_report_0" usebundle => _method_reporting_context("File present", "/tmp/test");
      "edummy_report" usebundle => log_rudder("File present /tmp/test if aix", "/tmp/test", "${class_prefix}_file_present__tmp_test", "${class_prefix}_file_present__tmp_test", @{args});

    !(linux)::
      "dummy_report" usebundle => _classes_noop("${class_prefix}_file_present__tmp_test");
      "dummy_report_1" usebundle => _method_reporting_context("File present", "/tmp/test");
      "dummy_report" usebundle => log_rudder("File present /tmp/test if linux", "/tmp/test", "${class_prefix}_file_present__tmp_test", "${class_prefix}_file_present__tmp_test", @{args});

    !(any.(aix))::
      "dummy_report" usebundle => _classes_noop("${class_prefix}_condition_from_command_test");
      "dummy_report_2" usebundle => _method_reporting_context("Condition from command", "test");
      "dummy_report" usebundle => log_rudder("Condition from command test if any.(aix)", "test", "${class_prefix}_condition_from_command_test", "${class_prefix}_condition_from_command_test", @{args});
}
~

Actions

Copy link

#36