Bug #9455: Changed compliance mode to allow overridable mode, but promises where not regenerated, and reporting was invalid - Rudder - Issue Tracker

Actions

Copy link

Bug #9455

closed

User story #1808: Add an Audit mode to Rudder: only check properties, no modification on nodes

Changed compliance mode to allow overridable mode, but promises where not regenerated, and reporting was invalid

Added by Nicolas CHARLES about 8 years ago. Updated about 8 years ago.

Status:

Released

Priority:

N/A

Assignee:

François ARMAND

Category:

Web - Compliance & node report

Target version:

4.0.0~rc1

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

I set directive based on MOTD to be in "Audit" mode, then I allowed the mode to be overridable.
Rules reported that it was in mixed mode, but running the agent showed that the Directive was in enforce mode
Promise where not regenerated - clicking on "Update" regenerated the policy with proper mode, and correct behaviour was enforced

The most confusing part was that the "Rules" page reported a mixed mode while it was false (policies distributed where pure enforce)

Actions

Copy link

Updated by Benoît PECCATTE about 8 years ago

Subject changed from Changed compliance mode to allow overridable mode, but prmose where not regenerated, and reporting was invalid to Changed compliance mode to allow overridable mode, but promises where not regenerated, and reporting was invalid

Actions

Copy link

Updated by François ARMAND about 8 years ago

I believe that the problem is that in the Rules (and node details) screen, we are using the current configuration (as in "live"), not the one of the last generation (which can be older, like it is in that use case).

I was thinking that the correct solution was to use information from the expected node configuration (ie data actually used in the node), but in fact, it would be extremelly confusing for an user, for example when he just changed a config and the displaying is still on the old one.

So perhaps the least surprising solution is to trigger a regeneration. We didn't do that because we wanted to let the user decide WHEN actually changing the config, in particular when going from audit to enforce. But it is confusing, and more so when everywhere in Rudder we trigger regeneration for everything.

So we should just trigger the regeneration.

Actions

Copy link