Project

General

Profile

Actions

Bug #12006

closed

Cannot define parameter for existing technique when change popup appears

Added by Nicolas CHARLES about 6 years ago. Updated about 6 years ago.

Status:
Rejected
Priority:
N/A
Category:
Web - Technique editor
Target version:
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Priority:
51
Name check:
Fix check:
Regression:

Description

Nothing happens when clicking on "Add parameter", but a JS error

Error: $scope.selectedTechnique.parameter is undefined
$scope.addParameter@https://192.168.45.2/ncf-builder/js/ncf.js:1001:5
functionCall/<@https://192.168.45.2/ncf-builder/js/angular-1.3.14.min.js:198:301
f@https://192.168.45.2/ncf-builder/js/angular-1.3.14.min.js:214:485
$eval@https://192.168.45.2/ncf-builder/js/angular-1.3.14.min.js:125:301
$apply@https://192.168.45.2/ncf-builder/js/angular-1.3.14.min.js:126:1
compile/</<@https://192.168.45.2/ncf-builder/js/angular-1.3.14.min.js:215:34
c@https://192.168.45.2/ncf-builder/js/angular-1.3.14.min.js:32:384
angular.js:11607:17

Note: it works fine for:
  1. newly created technique
  2. technique with data in local storage (if I leave, and come back, I have a popup asking to "keep change" or "update"; if I update, "Add parameter" fails)
Actions #1

Updated by Benoît PECCATTE about 6 years ago

  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
  • Priority changed from 0 to 52
Actions #2

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.3.0~beta1 to 4.3.0~rc1
Actions #3

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.3.0~rc1 to 4.3.0~rc2
  • Priority changed from 52 to 51
Actions #4

Updated by François ARMAND about 6 years ago

  • Translation missing: en.field_tag_list set to Blocking 4.3
Actions #5

Updated by Benoît PECCATTE about 6 years ago

  • Assignee set to François ARMAND

We need to recheck the problem with recent versions

Actions #6

Updated by François ARMAND about 6 years ago

  • Subject changed from Cannot define parameter for existing technique to Cannot define parameter for existing technique when change popup appears

I tested all these cases, which work:

- migration from 4.2 => 4.3 with existing techniques: able to add parameter,
- creating a new technique: able to add parameter,
- creating a new technique, log out, coming back to technique editor (but no "version changed, what do you want to do?" pop-up): able to add parameter.

So perhaps there is something broken with the pop-up, and so perhaps it is linked to: #12207

Actions #7

Updated by François ARMAND about 6 years ago

  • Translation missing: en.field_tag_list deleted (Blocking 4.3)

As the pop-up problem is not linked to 4.3, I'm removing the "blocking tag" (a correction from 4.1 can't block 4.3).

Actions #8

Updated by Nicolas CHARLES about 6 years ago

  • Status changed from New to Rejected

I could not reproduce ths issue either (with and without the popup), we can reject it

Actions

Also available in: Atom PDF