Project

General

Profile

Bug #12824

In directive, change input for parameter from technique editor from text to textarea

Added by Matthew Frost 6 months ago. Updated about 1 month ago.

Status:
Released
Priority:
N/A
Category:
Web - Config management
Target version:
Severity:
Critical - prevents main use of Rudder | no workaround | data loss | security
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Medium
Priority:
56

Description

Hello Rudder,

Let me start by saying amazing project what you are doing!

I have some feedback over the directives page of rudder currently I am trying to abstract data away from techniques and one thing I am creating is a technique to deploy certificates and add them to correct groups but I have noticed that the text field in directives is not multi-line.

So my question is would it be possible to make the text entry field in directives multi-line like that same text box in ensure file contents in the technique editor?

Thank you!!!


Subtasks

Bug #13752: Change "Common" Technique directives.st files to support multiline parametersReleasedNicolas CHARLES

Related issues

Related to Rudder - Bug #12825: Adding a parameter to an existing technique in technique editor without updating directives leads to unexpanded variable nameNew

Associated revisions

Revision 016706fd (diff)
Added by Vincent MEMBRÉ about 2 months ago

Fixes #12824: In directive, change input for parameter from technique editor from text to textarea

History

#1 Updated by Alexis MOUSSET 5 months ago

  • Category set to Web - Config management
  • Target version set to 4.3.4

#2 Updated by Benoît PECCATTE 5 months ago

  • Target version changed from 4.3.4 to 4.3.5

#3 Updated by François ARMAND 3 months ago

  • Severity set to Critical - prevents main use of Rudder | no workaround | data loss | security
  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
  • Effort required set to Small
  • Priority changed from 0 to 88

OK, so real long term correction is to be able to select the kind of field generated by the technique parameter.

The short term solution is to just use textarea in place of input text.

#4 Updated by François ARMAND 3 months ago

  • Related to Bug #12825: Adding a parameter to an existing technique in technique editor without updating directives leads to unexpanded variable name added

#5 Updated by Vincent MEMBRÉ 2 months ago

  • Target version changed from 4.3.5 to 4.3.6
  • Priority changed from 88 to 87

#6 Updated by François ARMAND 2 months ago

  • Subject changed from Directives Textbox to In directive, change input for parameter from technique editor from text to textarea

I'm not sure why I set it to "critical".

So, we should change the generated metadata to "textarea".
As that input is given to a cfengine bundle/dsc method parameter, we need to verify that:
- line returns are correctly quoted,
- big, long texts are not truncated / badly quoted.

#7 Updated by François ARMAND about 2 months ago

  • Assignee set to Vincent MEMBRÉ

#8 Updated by Vincent MEMBRÉ about 2 months ago

  • Effort required changed from Small to Medium
  • Priority changed from 87 to 56

This appear to be nastier to change.

I changed to a textarea field, but the string is formatted to be correctly indented with the promiser in the ruder-directives.cf file

If we use set this string:

Small text
multiline
to check

the rudder-directives.cf corresponding call is:

      "Global configuration for all nodes/test" usebundle => test("Small text
      multiline
      to check");

Adding spaces on the left of multiline and "to check" line

#9 Updated by Vincent MEMBRÉ about 2 months ago

  • Status changed from New to In progress

#10 Updated by Vincent MEMBRÉ about 2 months ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/2052

#11 Updated by Vincent MEMBRÉ about 2 months ago

  • Status changed from Pending technical review to Pending release

#12 Updated by Vincent MEMBRÉ about 1 month ago

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 4.3.6 and 5.0.2 which were released today.
Changelog
Changelog

Also available in: Atom PDF