Bug #12824
closed
In directive, change input for parameter from technique editor from text to textarea
Description
Hello Rudder,
Let me start by saying amazing project what you are doing!
I have some feedback over the directives page of rudder currently I am trying to abstract data away from techniques and one thing I am creating is a technique to deploy certificates and add them to correct groups but I have noticed that the text field in directives is not multi-line.
So my question is would it be possible to make the text entry field in directives multi-line like that same text box in ensure file contents in the technique editor?
Thank you!!!
Updated by Alexis Mousset over 5 years ago
- Category set to Web - Config management
- Target version set to 4.3.4
Updated by Benoît PECCATTE over 5 years ago
- Target version changed from 4.3.4 to 4.3.5
Updated by François ARMAND over 5 years ago
- Severity set to Critical - prevents main use of Rudder | no workaround | data loss | security
- User visibility set to Operational - other Techniques | Technique editor | Rudder settings
- Effort required set to Small
- Priority changed from 0 to 88
OK, so real long term correction is to be able to select the kind of field generated by the technique parameter.
The short term solution is to just use textarea in place of input text.
Updated by François ARMAND over 5 years ago
- Related to Bug #12825: Adding a parameter to an existing technique in technique editor without updating directives leads to unexpanded variable name added
Updated by Vincent MEMBRÉ over 5 years ago
- Target version changed from 4.3.5 to 4.3.6
- Priority changed from 88 to 87
Updated by François ARMAND over 5 years ago
- Subject changed from Directives Textbox to In directive, change input for parameter from technique editor from text to textarea
I'm not sure why I set it to "critical".
So, we should change the generated metadata to "textarea".
As that input is given to a cfengine bundle/dsc method parameter, we need to verify that:
- line returns are correctly quoted,
- big, long texts are not truncated / badly quoted.
Updated by Vincent MEMBRÉ over 5 years ago
- Effort required changed from Small to Medium
- Priority changed from 87 to 56
This appear to be nastier to change.
I changed to a textarea field, but the string is formatted to be correctly indented with the promiser in the ruder-directives.cf file
If we use set this string:
Small text multiline to check
the rudder-directives.cf corresponding call is:
"Global configuration for all nodes/test" usebundle => test("Small text
multiline
to check");
Adding spaces on the left of multiline and "to check" line
Updated by Vincent MEMBRÉ over 5 years ago
- Status changed from New to In progress
Updated by Vincent MEMBRÉ over 5 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Vincent MEMBRÉ to François ARMAND
- Pull Request set to https://github.com/Normation/rudder/pull/2052
Updated by Vincent MEMBRÉ over 5 years ago
- Status changed from Pending technical review to Pending release
Applied in changeset rudder|016706fd8993bc1f711b3793afc8007adf264726.
Updated by Vincent MEMBRÉ over 5 years ago
- Status changed from Pending release to Released