Bug #2799
closed
Change path of admin Rudder syslog
Added by François ARMAND over 11 years ago. Updated about 9 years ago.
Description
Following #2427, new logs are created and they go to the file:/var/log/rudder/webapp-opslog/rudder-webapp.log
That have to be changed to : /var/log/rudder/core/rudder-webapp.log
See http://www.rudder-project.org/redmine/issues/2427#note-10 for more details.
The ticket owner should also check that the directory "core" is created if it does not exists already (I believe it's the case).
Updated by Vincent MEMBRÉ over 11 years ago
- Status changed from 2 to Pending technical review
- % Done changed from 0 to 100
Applied in changeset a720159fbcd5ba870edc4ade590caf955debf175.
Updated by Nicolas PERRON over 11 years ago
Ooops, wrong issue. The last commit (0c703a7a2e55d509dca2068f50e023b27d68cacb) was a fix for #2800 .
Updated by Jonathan CLARKE over 11 years ago
- Status changed from Pending technical review to Discussion
This looks like the kind of change that requires a migration in packaging... Does anyone know if this has been done?
Updated by Vincent MEMBRÉ over 11 years ago
- Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
You're right Jon, something needs to be done at migration.
Current migration script overwrites user's logback.xml. So he loses everything he has modified before update (logging level).
We should check if file was modified.
if not replace it with new logback.xml.
Else we should keep the user logback.xml and check if property "OPSLOG_DIR" and appender "OPSLOG" exists
Property "OPSLOG_DIR":
<property name="OPSLOG_DIR" value="/var/log/rudder/core" />
if value has been modified we should keep it
Appender "OPSLOG":
<appender name="OPSLOG" class="ch.qos.logback.core.FileAppender">
<file>${OPSLOG_DIR}/rudder-webapp.log</file>
<append>true</append>
<encoder>
<pattern>%d{MMM dd HH:mm:ss} ${HOSTNAME} rudder[%logger]: [%level] %msg%n$
</encoder>
</appender>
Updated by Jonathan CLARKE over 11 years ago
- Assignee changed from Jonathan CLARKE to Nicolas PERRON
- Target version changed from 2.4.0~beta4 to 2.4.0~beta5
- Ensure new destination exists
- Move old log files to new destination
- Update config file to contain the new path
Note: it seems that the logback.xml file is not properly considered a config file... This should be a separate bug if it is true (I haven't checked).
Nicolas, can you deal with this please?
Updated by Nicolas PERRON over 11 years ago
- % Done changed from 100 to 80
Jonathan CLARKE wrote:
This needs a migration implemented in packaging:
- Ensure new destination exists
- Move old log files to new destination
- Update config file to contain the new path
Note: it seems that the logback.xml file is not properly considered a config file... This should be a separate bug if it is true (I haven't checked).
Nicolas, can you deal with this please?
Ok, i will make a migration script for this.
logback.xml wasn't considered as a config file so I have opened an issue: #2857
Updated by Jonathan CLARKE over 11 years ago
- Target version changed from 2.4.0~beta5 to 2.4.0~rc1
Updated by Jonathan CLARKE over 11 years ago
- Category changed from Web - Maintenance to 11
- Status changed from Discussion to 2
Updated by Nicolas PERRON over 11 years ago
- Status changed from 2 to In progress
How to deal with a partially migrated logs ?
Exemple: If the logback.xml has been replaced (since this file was not a config file until recently and that the change has been made for beta4) but the log files in /var/log/rudder/webapp-opslog were not moved.
I've seen this bug: #2872 which result in the replacement of the logrotate and then the impossibility to logrotate logs in /var/log/rudder/webapp-opslog.
Should archive all the logs in a tgz (like old-var_log_rudder_webapp-opslog.tgz)and move it to /var/log/rudder/core/ folder ?
Updated by Nicolas PERRON over 11 years ago
- Status changed from In progress to Pending technical review
- % Done changed from 80 to 100
Applied in changeset commit:0617911d4c783195346940e5a030a17d5d23ed25.
Updated by Nicolas PERRON over 11 years ago
Nicolas PERRON wrote:
How to deal with a partially migrated logs ?
Exemple: If the logback.xml has been replaced (since this file was not a config file until recently and that the change has been made for beta4) but the log files in /var/log/rudder/webapp-opslog were not moved.I've seen this bug: #2872 which result in the replacement of the logrotate and then the impossibility to logrotate logs in /var/log/rudder/webapp-opslog.
Should archive all the logs in a tgz (like old-var_log_rudder_webapp-opslog.tgz)and move it to /var/log/rudder/core/ folder ?
The action to do was only to move all the files from webapp-opslog to core and add them a suffix.
Updated by Nicolas PERRON over 11 years ago
- Target version changed from 2.4.0~rc1 to 2.4.0~beta5
Updated by Jonathan CLARKE over 11 years ago
- Status changed from Pending technical review to Released
Looks good to me!
Updated by Nicolas PERRON about 11 years ago
- Project changed from Rudder to 34
- Category deleted (
11)
Updated by Benoît PECCATTE about 9 years ago
- Project changed from 34 to Rudder
- Category set to Packaging