Project

General

Profile

Actions
Copy link

Bug #4480

closed

When restoring archive (full or groups) dynamic groups are created empty

Added by Vincent MEMBRÉ about 10 years ago. Updated almost 5 years ago.

Status:
Released
Priority:
1
Assignee:
Nicolas CHARLES
Category:
Web - Config management
Target version:
4.1.22
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
Critical - prevents main use of Rudder | no workaround | data loss | security
UX impact:
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Large
Priority:
0
Name check:
Fix check:
Regression:

Description

When your restore an archive, dynamic groups are restored empty, meaning that Rules won't be generated on those empty groups.

Since dynamic group reload occurs only every 5 minutes, Rules won't be deployed until taht event occurs.

It can be launched manually within the webapp, in Administration -> Settings page or by using the api on the url /api/dyngroup/reload

When groups are restaured and automatic group reloading should be launched before deployment.

Subtasks 1 (0 open — 1 closed)

Bug #14771: Use of unitialized value error when restoring archiveReleasedNicolas CHARLESActions

Related issues 5 (4 open — 1 closed)

Related to Rudder - Bug #14758: Accepting a change request on dynamic group, make the group empty leads an invalid policy generation ReleasedNicolas CHARLESActions
Related to Change validation - Bug #14766: When accepting a change request on a group, it's node list should be computed before savingNewActions
Related to Rudder - Architecture #14767: When we accept nodes, dynamic group should be automatically updated at the end of the acceptation, in a synchronized wayNewActions
Related to Rudder - Architecture #7471: Techniques should be reloaded before importing an archiveNewActions
Related to Rudder - Bug #15183: Reload technique library when restoring an archiveNewActions
Actions
Copy link
 #1

Updated by François ARMAND about 10 years ago

  • Status changed from New to 8

So, it's less trivial than initially thought:

- 1/ updating dynamic group is done asynchronously, so if we start it before starting promise generation, the result will certainly not be what we want (only partial update of groups ?)
- 2/ but if we issue a not asynchronous dynamic update, it may be long and make the import process even longer.

So, it seems that we want a way to start other things at the end of the dyngroup generation, something "on complete" (that does not exists for now).

Actions
Copy link
 #2

Updated by Nicolas CHARLES about 10 years ago

I guess the import time is not that bad, compared to the alternative of having incomplete promises.
Plus, the time of computing groups is in seconds, isn't it ?

Actions
Copy link
 #3

Updated by François ARMAND about 10 years ago

Yes, computing groups is quick. But you have to either wait for the next dynamic group generation (by default, 5 min if no luck), or trigger it by hand (need a second action). So it would be far better to have the trigger trigged automatically :)

Actions
Copy link
 #4

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 2.6.11 to 2.6.12
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 2.6.12 to 2.6.13
Actions
Copy link
 #6

Updated by Nicolas CHARLES about 10 years ago

Maybe we could:
- start a dyn update
- wait for x secondes
- deploy

what do you think of it ?

Actions
Copy link
 #7

Updated by Vincent MEMBRÉ almost 10 years ago

  • Target version changed from 2.6.13 to 2.6.14
Actions
Copy link
 #8

Updated by Jonathan CLARKE almost 10 years ago

  • Target version changed from 2.6.14 to 2.6.16
Actions
Copy link
 #9

Updated by Jonathan CLARKE almost 10 years ago

  • Target version changed from 2.6.16 to 2.6.17
Actions
Copy link
 #10

Updated by Nicolas PERRON over 9 years ago

  • Target version changed from 2.6.17 to 2.6.18
Actions
Copy link
 #11

Updated by Matthieu CERDA over 9 years ago

  • Target version changed from 2.6.18 to 2.6.19
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.6.19 to 2.6.20
Actions
Copy link
 #13

Updated by François ARMAND about 9 years ago

  • Target version changed from 2.6.20 to 2.10.10
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.10 to 2.10.11
Actions
Copy link
 #15

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.11 to 2.10.12
Actions
Copy link
 #16

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.12 to 2.10.13
Actions
Copy link
 #17

Updated by Benoît PECCATTE about 9 years ago

  • Status changed from 8 to New
Actions
Copy link
 #18

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.13 to 2.10.14
Actions
Copy link
 #19

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.10.14 to 2.10.15
Actions
Copy link
 #20

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.10.15 to 2.10.16
Actions
Copy link
 #21

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.10.16 to 2.10.17
Actions
Copy link
 #22

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.10.17 to 2.10.18
Actions
Copy link
 #23

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.10.18 to 2.10.19
Actions
Copy link
 #24

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.10.19 to 2.10.20
Actions
Copy link
 #25

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.10.20 to 2.11.18
Actions
Copy link
 #26

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.11.18 to 2.11.19
Actions
Copy link
 #27

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.11.19 to 2.11.20
Actions
Copy link
 #28

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.11.20 to 2.11.21
Actions
Copy link
 #29

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 2.11.21 to 2.11.22
Actions
Copy link
 #30

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 2.11.22 to 2.11.23
Actions
Copy link
 #31

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 2.11.23 to 2.11.24
Actions
Copy link
 #32

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 2.11.24 to 308
Actions
Copy link
 #33

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 308 to 3.1.14
Actions
Copy link
 #34

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.14 to 3.1.15
Actions
Copy link
 #35

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.15 to 3.1.16
Actions
Copy link
 #36

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.16 to 3.1.17
Actions
Copy link
 #37

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.17 to 3.1.18
Actions
Copy link
 #38

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 3.1.18 to 3.1.19
Actions
Copy link
 #39

Updated by François ARMAND about 7 years ago

  • Severity set to Critical - prevents main use of Rudder | no workaround | data loss | security
  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
  • Effort required set to Large
  • Priority set to 0
Actions
Copy link
 #40

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 3.1.19 to 3.1.20
Actions
Copy link
 #41

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 3.1.20 to 3.1.21
Actions
Copy link
 #42

Updated by François ARMAND almost 7 years ago

  • Priority changed from 0 to 39
Actions
Copy link
 #43

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 3.1.21 to 3.1.22
Actions
Copy link
 #44

Updated by Benoît PECCATTE almost 7 years ago

  • Priority changed from 39 to 40
Actions
Copy link
 #45

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.22 to 3.1.23
Actions
Copy link
 #46

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.23 to 3.1.24
Actions
Copy link
 #47

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.24 to 3.1.25
  • Priority changed from 40 to 41
Actions
Copy link
 #48

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.25 to 387
Actions
Copy link
 #49

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 387 to 4.1.10
Actions
Copy link
 #50

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.10 to 4.1.11
  • Priority changed from 41 to 42
Actions
Copy link
 #51

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.11 to 4.1.12
  • Priority changed from 42 to 43
Actions
Copy link
 #52

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.12 to 4.1.13
Actions
Copy link
 #53

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.13 to 4.1.14
  • Priority changed from 43 to 44
Actions
Copy link
 #54

Updated by Benoît PECCATTE over 5 years ago

  • Target version changed from 4.1.14 to 4.1.15
Actions
Copy link
 #55

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.15 to 4.1.16
  • Priority changed from 44 to 45
Actions
Copy link
 #56

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.16 to 4.1.17
Actions
Copy link
 #57

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.17 to 4.1.18
  • Priority changed from 45 to 0
Actions
Copy link
 #58

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.18 to 4.1.19
Actions
Copy link
 #59

Updated by Alexis Mousset about 5 years ago

  • Target version changed from 4.1.19 to 4.1.20
Actions
Copy link
 #60

Updated by Nicolas CHARLES almost 5 years ago

it also happens when validating change request, but it's even worse as it does not trigger a dynamic group update - so it lasts much longer in an invalid state

Actions
Copy link
 #61

Updated by Nicolas CHARLES almost 5 years ago

  • Related to Bug #14758: Accepting a change request on dynamic group, make the group empty leads an invalid policy generation added
Actions
Copy link
 #62

Updated by Nicolas CHARLES almost 5 years ago

  • Target version changed from 4.1.20 to 5.0.10

Targeting to 5.0, as #14758 take care of the workaround in 4.1

when importing an archive, it should compute node list before saving. This should be synchronized, as others actions can happen at the same time (accept node, change request, etc), and this computation should block loading nodes list in policy generation

Actions
Copy link
 #63

Updated by Nicolas CHARLES almost 5 years ago

  • Related to Bug #14766: When accepting a change request on a group, it's node list should be computed before saving added
Actions
Copy link
 #64

Updated by Nicolas CHARLES almost 5 years ago

  • Related to Architecture #14767: When we accept nodes, dynamic group should be automatically updated at the end of the acceptation, in a synchronized way added
Actions
Copy link
 #65

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 5.0.10 to 4.1.22
Actions
Copy link
 #66

Updated by Vincent MEMBRÉ almost 5 years ago

  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ
Actions
Copy link
 #67

Updated by Vincent MEMBRÉ almost 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder/pull/2204
Actions
Copy link
 #68

Updated by Vincent MEMBRÉ almost 5 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #70

Updated by Vincent MEMBRÉ almost 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.22, 4.3.12 and 5.0.10 which were released today.

Actions
Copy link
 #71

Updated by Vincent MEMBRÉ almost 5 years ago

  • Related to Architecture #7471: Techniques should be reloaded before importing an archive added
Actions
Copy link
 #72

Updated by Vincent MEMBRÉ almost 5 years ago

  • Related to Bug #15183: Reload technique library when restoring an archive added
Actions
Copy link

Also available in: Atom PDF