Project

General

Profile

Actions
Copy link

Bug #4709

closed

When a node is deleted, its generated promises are not removed

Added by Jonathan CLARKE over 10 years ago. Updated almost 6 years ago.

Status:
Released
Priority:
3
Assignee:
Benoît PECCATTE
Category:
Web - Nodes & inventories
Target version:
4.1.17
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

I just removed a node from Rudder by pressing the "Delete node" button in the interface, but it's promises are still on the disk. They should be removed.

Found in Rudder 2.10.0, but probably present in older versions too.

Related issues 2 (0 open — 2 closed)

Related to Rudder - Bug #5462: Relay servers keeps sending inventories of their managed nodes at every runReleasedJonathan CLARKE2014-09-02Actions
Is duplicate of Rudder - Question #9719: Node deletes are not properly cleaned upResolvedActions
Actions
Copy link
 #1

Updated by Vincent MEMBRÉ over 10 years ago

  • Target version changed from 2.6.13 to 2.6.14
Actions
Copy link
 #2

Updated by Jonathan CLARKE over 10 years ago

  • Target version changed from 2.6.14 to 2.6.16
Actions
Copy link
 #3

Updated by Jonathan CLARKE over 10 years ago

  • Target version changed from 2.6.16 to 2.6.17
Actions
Copy link
 #4

Updated by Nicolas PERRON over 10 years ago

  • Target version changed from 2.6.17 to 2.6.18
Actions
Copy link
 #5

Updated by Matthieu CERDA about 10 years ago

  • Target version changed from 2.6.18 to 2.6.19
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 2.6.19 to 2.6.20
Actions
Copy link
 #7

Updated by François ARMAND almost 10 years ago

  • Status changed from 8 to New
  • Assignee set to Nicolas CHARLES
  • Target version changed from 2.6.20 to 2.10.10

Nico, how do you think we should handle that ?

I see several solutions:
- trigger a rm rf ${nodeid} or something alike from rudder UI when a node is deleted;
on each promise generation, delete all unknown files in /var/rudder/share to keep only existing nodes,
- have a cfengine (sytem) promise making the cleaning for us

What do you think is best ?
The direct removal is über simple but not too convergent, the second solution add time to generation, the last may not scale to well with thousand of nodes... But still seem to be the best.

Actions
Copy link
 #8

Updated by Nicolas CHARLES almost 10 years ago

First or second solution should be the best
third one doesn't seem really relevant; passing to cfengine the list of all managed nodes is a bit risky

We also need to have a way to propagate this change to relay server

Actions
Copy link
 #9

Updated by François ARMAND almost 10 years ago

I don't understand why it's risky: it's exactly what is done for the autorization and promise transmission. And it will be a simple way to transfert that to relay node. Basically, it say: if you serve promises, you also have to ensure that no garbage is available around what is served, and clean it if needed.

Could you explain what scares you in that solution ?

Actions
Copy link
 #10

Updated by Vincent MEMBRÉ almost 10 years ago

  • Target version changed from 2.10.10 to 2.10.11
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.11 to 2.10.12
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.12 to 2.10.13
Actions
Copy link
 #13

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.13 to 2.10.14
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.14 to 2.10.15
Actions
Copy link
 #15

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.15 to 2.10.16
Actions
Copy link
 #16

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.16 to 2.10.17
Actions
Copy link
 #17

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.17 to 2.10.18
Actions
Copy link
 #18

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.18 to 2.10.19
Actions
Copy link
 #19

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.19 to 2.10.20
Actions
Copy link
 #20

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.10.20 to 2.11.18
Actions
Copy link
 #21

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.11.18 to 2.11.19
Actions
Copy link
 #22

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.19 to 2.11.20
Actions
Copy link
 #23

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.20 to 2.11.21
Actions
Copy link
 #24

Updated by François ARMAND over 8 years ago

  • Related to Bug #7288: Policy does not get deleted when changing relays added
Actions
Copy link
 #25

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.21 to 2.11.22
Actions
Copy link
 #26

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.22 to 2.11.23
Actions
Copy link
 #27

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.23 to 2.11.24
Actions
Copy link
 #28

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.11.24 to 308
Actions
Copy link
 #29

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 308 to 3.1.14
Actions
Copy link
 #30

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.14 to 3.1.15
Actions
Copy link
 #31

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.15 to 3.1.16
Actions
Copy link
 #32

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.16 to 3.1.17
Actions
Copy link
 #33

Updated by Janos Mattyasovszky almost 8 years ago

  • Related to Question #9719: Node deletes are not properly cleaned up added
Actions
Copy link
 #34

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.1.17 to 3.1.18
Actions
Copy link
 #35

Updated by Janos Mattyasovszky almost 8 years ago

Just FYI, our last policy generation was on Dec 8, 1PM.
  • 8593 folders are in /var/rudder/share for end-nodes:
  • 1912 folders are not from the latest polgen (decom'ed servers).
  • 6681 folders container the valid promises for the current nodes.
Actions
Copy link
 #36

Updated by François ARMAND almost 8 years ago

  • Status changed from New to In progress
  • Assignee changed from Nicolas CHARLES to François ARMAND
Actions
Copy link
 #37

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.1.18 to 3.1.19
Actions
Copy link
 #38

Updated by Benoît PECCATTE over 7 years ago

  • Subject changed from When a node is deleted, it's generated promises are not removed to When a node is deleted, its generated promises are not removed
  • Status changed from In progress to Rejected

Duplicate of #9719

Actions
Copy link
 #39

Updated by François ARMAND over 7 years ago

  • Related to Bug #5154: Node key not deleted after deleting a node in the web ui added
Actions
Copy link
 #40

Updated by François ARMAND over 7 years ago

  • Related to deleted (Bug #5154: Node key not deleted after deleting a node in the web ui)
Actions
Copy link
 #41

Updated by François ARMAND over 7 years ago

  • Related to deleted (Bug #7288: Policy does not get deleted when changing relays)
Actions
Copy link
 #42

Updated by François ARMAND over 7 years ago

  • Related to deleted (Question #9719: Node deletes are not properly cleaned up)
Actions
Copy link
 #43

Updated by François ARMAND over 7 years ago

  • Is duplicate of Question #9719: Node deletes are not properly cleaned up added
Actions
Copy link
 #44

Updated by François ARMAND about 6 years ago

  • Status changed from Rejected to New
  • Target version changed from 3.1.19 to 4.1.17
  • Priority set to 0

It is not actually a duplicate of the referenced bug which just list other tickets.

Actions
Copy link
 #45

Updated by François ARMAND about 6 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from François ARMAND to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder/pull/2081
Actions
Copy link
 #46

Updated by François ARMAND about 6 years ago

  • Assignee changed from Benoît PECCATTE to Nicolas CHARLES
Actions
Copy link
 #47

Updated by François ARMAND about 6 years ago

  • Assignee changed from Nicolas CHARLES to Benoît PECCATTE
Actions
Copy link
 #48

Updated by François ARMAND about 6 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #49

Updated by Vincent MEMBRÉ almost 6 years ago

  • Status changed from Pending release to Released
This bug has been fixed in Rudder 4.1.17, 4.3.7 and 5.0.3 which were released today. 
Changelog
 Changelog
 Changelog
Actions
Copy link

Also available in: Atom PDF