Bug #8321
closed
File edit methods return a kept class even when they repaired the file
Added by Jonathan CLARKE over 8 years ago.
Updated over 2 years ago.
Description
According to https://github.com/Normation/ncf/pull/357/files#r63663063:
Even if we edit a file, and the repaired class is set, because the file already exists, CFEngine thinks the promise is kept, therefore defining both result classes. Reason is most of them create the file if not existing, but if the file is already there, part of this promise is kept, hence the kept result
We should look into a workaround to avoid this confusing and nasty kept class. If it comes from the "create => true" part of the promise, maybe just separate this into two promises, and report only on the second? If not, how about a checksum before and after the file edit promise, and if the checksum differs, then force the repaired class, if not force the kept class?
- Has duplicate Bug #8320: Most file edition generic method return kept and repaired when a file has been modified added
- Subject changed from File edi methods return a kept class even when they repaired the file to File edit methods return a kept class even when they repaired the file
- Description updated (diff)
Looks like we need a method to "sanitize" result classes (remove kept if there's >= 1 repaired, remove repaired if there's >= error)
- Assignee set to Benoît PECCATTE
- Status changed from New to In progress
- Status changed from In progress to Pending technical review
- Assignee changed from Benoît PECCATTE to Nicolas CHARLES
- Pull Request set to https://github.com/Normation/ncf/pull/388
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset commit:04dd796b50ec70b3c95e41917936ef249d312f84.
- Status changed from Pending release to Released
- Target version changed from 0.x to ncf-0.x
- Priority set to 0
- Project changed from 41 to Rudder
- Category set to Generic methods
Also available in: Atom
PDF