Project

General

Profile

Actions

Bug #8321

closed

File edit methods return a kept class even when they repaired the file

Added by Jonathan CLARKE almost 8 years ago. Updated almost 2 years ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

According to https://github.com/Normation/ncf/pull/357/files#r63663063:

Even if we edit a file, and the repaired class is set, because the file already exists, CFEngine thinks the promise is kept, therefore defining both result classes. Reason is most of them create the file if not existing, but if the file is already there, part of this promise is kept, hence the kept result

We should look into a workaround to avoid this confusing and nasty kept class. If it comes from the "create => true" part of the promise, maybe just separate this into two promises, and report only on the second? If not, how about a checksum before and after the file edit promise, and if the checksum differs, then force the repaired class, if not force the kept class?


Subtasks 3 (0 open3 closed)

Bug #8574: File edit methods return a kept class even when they repaired the fileRejectedActions
Bug #8651: Merge error in 8321ReleasedBenoît PECCATTEActions
Bug #8653: The cancel body doesn't existReleasedAlexis MoussetActions

Related issues 1 (0 open1 closed)

Has duplicate Rudder - Bug #8320: Most file edition generic method return kept and repaired when a file has been modifiedRejectedActions
Actions

Also available in: Atom PDF