Project

General

Profile

Actions
Copy link

Architecture #8683

closed

check_* methods output error messages when the result of a check is "no"

Added by Nicolas CHARLES almost 8 years ago. Updated 8 months ago.

Status:
Resolved
Priority:
N/A
Assignee:
-
Category:
Generic methods
Target version:
8.1.0~alpha1
Pull Request:
Effort required:
Name check:
Fix check:
Regression:

Description

service_ensure_stopped use service_check_running to check is a service is running or not.
service_check_running_ps checks if the service is running, and if it is, it returns a success class, if it is not, it returns an error class

So when the service is stopped (which is the expected status), service_check_running_ps outputs an error message 

R: [ERROR] Promise could not be repaired, error encountered: Check if the service SERVICENAME is started using ps

which is really confusing for a normal person not knowing the internals of ncf

Related issues 3 (0 open — 3 closed)

Is duplicate of Rudder - User story #6368: Methods named check_* should have an equivalent without reportingResolvedActions
Has duplicate Rudder - Bug #8846: broken report from Directory check existsRejectedActions
Has duplicate Rudder - Bug #15080: Service technique reports a warning after stopping a serviceRejectedActions
Actions
Copy link

Also available in: Atom PDF