Rudder

Moreover: the new technique creation is now broken at all:

An Error occured! Unknown internal error during technique writing
Details: Cause: expected string or buffer Traceback (most recent call last): File "/usr/share/ncf/api/ncf_api_flask_app/views.py", line 154, in create_technique ncf.write_technique(technique,path) File "/usr/share/ncf/tools/ncf.py", line 606, in write_technique content = generate_technique_content(technique_metadata, methods) File "/usr/share/ncf/tools/ncf.py", line 499, in generate_technique_content check = ncf_constraints.check_parameter(arg, arg_constraint) File "/usr/share/ncf/tools/ncf_constraints.py", line 121, in check_parameter if re.search(r'[$@][{(][$@{(a-zA-Z0-9[\]_.-]+[})]', parameter_value) is not None : File "/usr/lib/python2.7/re.py", line 142, in search return _compile(pattern, flags).search(string) TypeError: expected string or buffer 

Hello Dmitry, thanks for reporting this issue! and sorry about this ...

What is the version of the ncf package installed ?

Is technique 'TZ_UTC' a new technique or an existing technique ?

I'm gonna try to reproduce it

TZ_UTC is old technique (but that I tried to resave).
Now I try to create completelly new technique as a hot workaround.

# dpkg -l | grep ncf
ii  ncf                                  1.0.0.201607292058-trusty1       all          ncf - CFEngine framework
ii  ncf-api-virtualenv                   3.2.5-trusty1                    all          ncf - CFEngine framework

• The error in the comment above appears on saving e.g. "Command execution result" with not all fields filled. (So, it's bacause of invalid pre-check, not a total destroy.)

Found the first issue (on logger arity), as stated in the error messages, it generate wrong bundle call for rudder_reproting, making a patch.

On the second one, in your new technique, what methods have you added ? I created techniques without problems, but did'nt tried with all methods ...

Thanks, so you kept blank fields in some 'command execution result' and you got an error on saving ?

The error is ok (you cannot have blank fields in this methods) but the error message is really not helpful, and the UI should prevent you from saving

I'll improve the error message and also the UI checks!

as an easy workaround, you can modify that file /var/rudder/share/42a34eff-213c-42fd-abf7-6fef5cca8d27/rules.new/cfengine-community/TZ_UTC/1.0/rudder_reporting.cf on line 7 and 11

The line should look line this

'log_rudder(param1, param2)'

You should change them to:

'log_rudder(param1, param2, "", "")'

Then launch an update on Rudder webapp

I'll give you a patch to fix how those files are generated

#find /var/rudder/share/ -name rudder_reporting.cf | wc -l
100

# find /var/rudder/share/ -name rudder_reporting.cf | xargs -I XXX sed -ri 's/(log_rudder\([^)]+)/\1, "", ""/g' XXX

Ok, the patch works, but all user techniques have to be saved again (to implement ncf_rudder.py).
So, there although must be "runtime" patch to update existing directives (techniques) during rudder upgrade.

Do your other rudder_reporting.cf file contains log_rudder with 2 parameters, log_rudder with 4 parameters or logger_rudder with 2 parameters?

First one is wrong (and was generated by our current cnf ...
Second one is what we should generate ( And I thought it was ok, but a merge broke this ...)
Third one is OK (use a deprecated method, but that what we use on version 3.1 of Rudder)

If you have first One then we need a migration process else other are OK for now (Though if we migrated third case automatically it whould be better ...)

If I read my history correctly:

Rudder 3.2.5, generates log_rudder with 2 parameters => Wrong, corrected here
Rudder 3.2.4, generated log_rudder with 4 paramters => What we want ( was fixed in #8475, but broken by merge commit:04c18f )
Before Rudder 3.2.4, logger_rudder with 2 parameters => Ok

On those which are saved in Technique editor after patch:

    !(ubuntu)::
      "dummy_report" usebundle => _classes_noop("command_execution_result_timedatectl___grep_Timezone___grep__q_UTC");
      "dummy_report" usebundle => log_rudder("Command execution result timedatectl | grep Timezone | grep -q UTC if ubuntu", "command_execution_result_timedatectl___grep_Timezone___grep__q_UTC", "", "");

On old ncf:

    !(ubuntu)::
      "dummy_report" usebundle => _classes_noop("file_ensure_block_in_section__etc_multipath_conf");
      "dummy_report" usebundle => log_rudder("File ensure block in section /etc/multipath.conf if ubuntu", "file_ensure_block_in_section__etc_multipath_conf");